All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/8] IPMI: Hold ATTN until upper layer ready
@ 2008-02-13 16:20 Corey Minyard
  0 siblings, 0 replies; only message in thread
From: Corey Minyard @ 2008-02-13 16:20 UTC (permalink / raw)
  To: Linux Kernel; +Cc: Andrew Morton, Patrick Schoeller, OpenIPMI Developers

From: Corey Minyard <cminyard@mvista.com>

Hold handling of ATTN until the upper layer has reported that it is
ready.

Signed-off-by: Corey Minyard <cminyard@mvista.com>
Cc: Patrick Schoeller <Patrick.Schoeller@hp.com>
---

Index: linux-2.6.24/drivers/char/ipmi/ipmi_si_intf.c
===================================================================
--- linux-2.6.24.orig/drivers/char/ipmi/ipmi_si_intf.c
+++ linux-2.6.24/drivers/char/ipmi/ipmi_si_intf.c
@@ -723,8 +723,11 @@ static enum si_sm_result smi_event_handl
 		si_sm_result = smi_info->handlers->event(smi_info->si_sm, 0);
 	}
 
-	/* We prefer handling attn over new messages. */
-	if (si_sm_result == SI_SM_ATTN)
+	/*
+	 * We prefer handling attn over new messages.  But don't do
+	 * this if there is not yet an upper layer to handle anything.
+	 */
+	if (likely(smi_info->intf) && si_sm_result == SI_SM_ATTN)
 	{
 		unsigned char msg[2];
 

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-02-13 16:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-13 16:20 [PATCH 1/8] IPMI: Hold ATTN until upper layer ready Corey Minyard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.