* [PATCH] ACPI suspend: Execute _WAK with the right argument
@ 2008-02-12 23:32 Rafael J. Wysocki
2008-02-12 23:45 ` Pavel Machek
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Rafael J. Wysocki @ 2008-02-12 23:32 UTC (permalink / raw)
To: Len Brown
Cc: ACPI Devel Maling List, Andrew Morton, LKML, Mirco Tischler,
Pavel Machek, pm list
From: Rafael J. Wysocki <rjw@sisk.pl>
The _WAK global ACPI control method has to be called with the
argument representing the sleep state being exited. Make it happen.
Special thanks to Mirco Tischler <mt-ml@gmx.de> for reporting the
problem and debugging.
Reported-by: Mirco Tischler <mt-ml@gmx.de>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/acpi/hardware/hwsleep.c | 1 +
1 file changed, 1 insertion(+)
Index: linux-2.6/drivers/acpi/hardware/hwsleep.c
===================================================================
--- linux-2.6.orig/drivers/acpi/hardware/hwsleep.c
+++ linux-2.6/drivers/acpi/hardware/hwsleep.c
@@ -616,6 +616,7 @@ acpi_status acpi_leave_sleep_state(u8 sl
return_ACPI_STATUS(status);
}
+ arg.integer.value = sleep_state;
status = acpi_evaluate_object(NULL, METHOD_NAME__WAK, &arg_list, NULL);
if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) {
ACPI_EXCEPTION((AE_INFO, status, "During Method _WAK"));
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ACPI suspend: Execute _WAK with the right argument
2008-02-12 23:32 [PATCH] ACPI suspend: Execute _WAK with the right argument Rafael J. Wysocki
@ 2008-02-12 23:45 ` Pavel Machek
2008-02-12 23:45 ` Pavel Machek
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Pavel Machek @ 2008-02-12 23:45 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: LKML, Mirco Tischler, ACPI Devel Maling List, Andrew Morton,
pm list
On Wed 2008-02-13 00:32:16, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> The _WAK global ACPI control method has to be called with the
> argument representing the sleep state being exited. Make it happen.
>
> Special thanks to Mirco Tischler <mt-ml@gmx.de> for reporting the
> problem and debugging.
>
> Reported-by: Mirco Tischler <mt-ml@gmx.de>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
ACK. AFAICT this is 2.6.25 material.
Pavel
> ---
> drivers/acpi/hardware/hwsleep.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux-2.6/drivers/acpi/hardware/hwsleep.c
> ===================================================================
> --- linux-2.6.orig/drivers/acpi/hardware/hwsleep.c
> +++ linux-2.6/drivers/acpi/hardware/hwsleep.c
> @@ -616,6 +616,7 @@ acpi_status acpi_leave_sleep_state(u8 sl
> return_ACPI_STATUS(status);
> }
>
> + arg.integer.value = sleep_state;
> status = acpi_evaluate_object(NULL, METHOD_NAME__WAK, &arg_list, NULL);
> if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) {
> ACPI_EXCEPTION((AE_INFO, status, "During Method _WAK"));
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ACPI suspend: Execute _WAK with the right argument
2008-02-12 23:32 [PATCH] ACPI suspend: Execute _WAK with the right argument Rafael J. Wysocki
2008-02-12 23:45 ` Pavel Machek
@ 2008-02-12 23:45 ` Pavel Machek
2008-02-12 23:49 ` Rafael J. Wysocki
2008-02-12 23:49 ` Rafael J. Wysocki
2008-02-14 5:30 ` Len Brown
2008-02-14 5:30 ` Len Brown
3 siblings, 2 replies; 8+ messages in thread
From: Pavel Machek @ 2008-02-12 23:45 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Len Brown, ACPI Devel Maling List, Andrew Morton, LKML,
Mirco Tischler, pm list
On Wed 2008-02-13 00:32:16, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> The _WAK global ACPI control method has to be called with the
> argument representing the sleep state being exited. Make it happen.
>
> Special thanks to Mirco Tischler <mt-ml@gmx.de> for reporting the
> problem and debugging.
>
> Reported-by: Mirco Tischler <mt-ml@gmx.de>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
ACK. AFAICT this is 2.6.25 material.
Pavel
> ---
> drivers/acpi/hardware/hwsleep.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux-2.6/drivers/acpi/hardware/hwsleep.c
> ===================================================================
> --- linux-2.6.orig/drivers/acpi/hardware/hwsleep.c
> +++ linux-2.6/drivers/acpi/hardware/hwsleep.c
> @@ -616,6 +616,7 @@ acpi_status acpi_leave_sleep_state(u8 sl
> return_ACPI_STATUS(status);
> }
>
> + arg.integer.value = sleep_state;
> status = acpi_evaluate_object(NULL, METHOD_NAME__WAK, &arg_list, NULL);
> if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) {
> ACPI_EXCEPTION((AE_INFO, status, "During Method _WAK"));
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ACPI suspend: Execute _WAK with the right argument
2008-02-12 23:45 ` Pavel Machek
@ 2008-02-12 23:49 ` Rafael J. Wysocki
2008-02-12 23:49 ` Rafael J. Wysocki
1 sibling, 0 replies; 8+ messages in thread
From: Rafael J. Wysocki @ 2008-02-12 23:49 UTC (permalink / raw)
To: Pavel Machek
Cc: Len Brown, ACPI Devel Maling List, Andrew Morton, LKML,
Mirco Tischler, pm list
On Wednesday, 13 of February 2008, Pavel Machek wrote:
> On Wed 2008-02-13 00:32:16, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> >
> > The _WAK global ACPI control method has to be called with the
> > argument representing the sleep state being exited. Make it happen.
> >
> > Special thanks to Mirco Tischler <mt-ml@gmx.de> for reporting the
> > problem and debugging.
> >
> > Reported-by: Mirco Tischler <mt-ml@gmx.de>
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
>
> ACK. AFAICT this is 2.6.25 material.
Sure, it certainly is. The bug has been breaking suspend on people's boxes
already.
Thanks,
Rafael
> > ---
> > drivers/acpi/hardware/hwsleep.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > Index: linux-2.6/drivers/acpi/hardware/hwsleep.c
> > ===================================================================
> > --- linux-2.6.orig/drivers/acpi/hardware/hwsleep.c
> > +++ linux-2.6/drivers/acpi/hardware/hwsleep.c
> > @@ -616,6 +616,7 @@ acpi_status acpi_leave_sleep_state(u8 sl
> > return_ACPI_STATUS(status);
> > }
> >
> > + arg.integer.value = sleep_state;
> > status = acpi_evaluate_object(NULL, METHOD_NAME__WAK, &arg_list, NULL);
> > if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) {
> > ACPI_EXCEPTION((AE_INFO, status, "During Method _WAK"));
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ACPI suspend: Execute _WAK with the right argument
2008-02-12 23:45 ` Pavel Machek
2008-02-12 23:49 ` Rafael J. Wysocki
@ 2008-02-12 23:49 ` Rafael J. Wysocki
1 sibling, 0 replies; 8+ messages in thread
From: Rafael J. Wysocki @ 2008-02-12 23:49 UTC (permalink / raw)
To: Pavel Machek
Cc: LKML, Mirco Tischler, ACPI Devel Maling List, Andrew Morton,
pm list
On Wednesday, 13 of February 2008, Pavel Machek wrote:
> On Wed 2008-02-13 00:32:16, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> >
> > The _WAK global ACPI control method has to be called with the
> > argument representing the sleep state being exited. Make it happen.
> >
> > Special thanks to Mirco Tischler <mt-ml@gmx.de> for reporting the
> > problem and debugging.
> >
> > Reported-by: Mirco Tischler <mt-ml@gmx.de>
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
>
> ACK. AFAICT this is 2.6.25 material.
Sure, it certainly is. The bug has been breaking suspend on people's boxes
already.
Thanks,
Rafael
> > ---
> > drivers/acpi/hardware/hwsleep.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > Index: linux-2.6/drivers/acpi/hardware/hwsleep.c
> > ===================================================================
> > --- linux-2.6.orig/drivers/acpi/hardware/hwsleep.c
> > +++ linux-2.6/drivers/acpi/hardware/hwsleep.c
> > @@ -616,6 +616,7 @@ acpi_status acpi_leave_sleep_state(u8 sl
> > return_ACPI_STATUS(status);
> > }
> >
> > + arg.integer.value = sleep_state;
> > status = acpi_evaluate_object(NULL, METHOD_NAME__WAK, &arg_list, NULL);
> > if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) {
> > ACPI_EXCEPTION((AE_INFO, status, "During Method _WAK"));
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ACPI suspend: Execute _WAK with the right argument
2008-02-12 23:32 [PATCH] ACPI suspend: Execute _WAK with the right argument Rafael J. Wysocki
2008-02-12 23:45 ` Pavel Machek
2008-02-12 23:45 ` Pavel Machek
@ 2008-02-14 5:30 ` Len Brown
2008-02-14 5:30 ` Len Brown
3 siblings, 0 replies; 8+ messages in thread
From: Len Brown @ 2008-02-14 5:30 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: LKML, Mirco Tischler, ACPI Devel Maling List, Andrew Morton,
pm list
applied
thanks for quickly finding and fixing this 2.6.25-rc1 regression.
-len
On Tuesday 12 February 2008 18:32, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> The _WAK global ACPI control method has to be called with the
> argument representing the sleep state being exited. Make it happen.
>
> Special thanks to Mirco Tischler <mt-ml@gmx.de> for reporting the
> problem and debugging.
>
> Reported-by: Mirco Tischler <mt-ml@gmx.de>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> ---
> drivers/acpi/hardware/hwsleep.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux-2.6/drivers/acpi/hardware/hwsleep.c
> ===================================================================
> --- linux-2.6.orig/drivers/acpi/hardware/hwsleep.c
> +++ linux-2.6/drivers/acpi/hardware/hwsleep.c
> @@ -616,6 +616,7 @@ acpi_status acpi_leave_sleep_state(u8 sl
> return_ACPI_STATUS(status);
> }
>
> + arg.integer.value = sleep_state;
> status = acpi_evaluate_object(NULL, METHOD_NAME__WAK, &arg_list, NULL);
> if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) {
> ACPI_EXCEPTION((AE_INFO, status, "During Method _WAK"));
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ACPI suspend: Execute _WAK with the right argument
2008-02-12 23:32 [PATCH] ACPI suspend: Execute _WAK with the right argument Rafael J. Wysocki
` (2 preceding siblings ...)
2008-02-14 5:30 ` Len Brown
@ 2008-02-14 5:30 ` Len Brown
3 siblings, 0 replies; 8+ messages in thread
From: Len Brown @ 2008-02-14 5:30 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: ACPI Devel Maling List, Andrew Morton, LKML, Mirco Tischler,
Pavel Machek, pm list
applied
thanks for quickly finding and fixing this 2.6.25-rc1 regression.
-len
On Tuesday 12 February 2008 18:32, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> The _WAK global ACPI control method has to be called with the
> argument representing the sleep state being exited. Make it happen.
>
> Special thanks to Mirco Tischler <mt-ml@gmx.de> for reporting the
> problem and debugging.
>
> Reported-by: Mirco Tischler <mt-ml@gmx.de>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> ---
> drivers/acpi/hardware/hwsleep.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux-2.6/drivers/acpi/hardware/hwsleep.c
> ===================================================================
> --- linux-2.6.orig/drivers/acpi/hardware/hwsleep.c
> +++ linux-2.6/drivers/acpi/hardware/hwsleep.c
> @@ -616,6 +616,7 @@ acpi_status acpi_leave_sleep_state(u8 sl
> return_ACPI_STATUS(status);
> }
>
> + arg.integer.value = sleep_state;
> status = acpi_evaluate_object(NULL, METHOD_NAME__WAK, &arg_list, NULL);
> if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) {
> ACPI_EXCEPTION((AE_INFO, status, "During Method _WAK"));
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ACPI suspend: Execute _WAK with the right argument
@ 2008-02-12 23:32 Rafael J. Wysocki
0 siblings, 0 replies; 8+ messages in thread
From: Rafael J. Wysocki @ 2008-02-12 23:32 UTC (permalink / raw)
To: Len Brown
Cc: LKML, Mirco Tischler, ACPI Devel Maling List, Andrew Morton,
pm list
From: Rafael J. Wysocki <rjw@sisk.pl>
The _WAK global ACPI control method has to be called with the
argument representing the sleep state being exited. Make it happen.
Special thanks to Mirco Tischler <mt-ml@gmx.de> for reporting the
problem and debugging.
Reported-by: Mirco Tischler <mt-ml@gmx.de>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/acpi/hardware/hwsleep.c | 1 +
1 file changed, 1 insertion(+)
Index: linux-2.6/drivers/acpi/hardware/hwsleep.c
===================================================================
--- linux-2.6.orig/drivers/acpi/hardware/hwsleep.c
+++ linux-2.6/drivers/acpi/hardware/hwsleep.c
@@ -616,6 +616,7 @@ acpi_status acpi_leave_sleep_state(u8 sl
return_ACPI_STATUS(status);
}
+ arg.integer.value = sleep_state;
status = acpi_evaluate_object(NULL, METHOD_NAME__WAK, &arg_list, NULL);
if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) {
ACPI_EXCEPTION((AE_INFO, status, "During Method _WAK"));
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2008-02-14 5:31 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-12 23:32 [PATCH] ACPI suspend: Execute _WAK with the right argument Rafael J. Wysocki
2008-02-12 23:45 ` Pavel Machek
2008-02-12 23:45 ` Pavel Machek
2008-02-12 23:49 ` Rafael J. Wysocki
2008-02-12 23:49 ` Rafael J. Wysocki
2008-02-14 5:30 ` Len Brown
2008-02-14 5:30 ` Len Brown
-- strict thread matches above, loose matches on Subject: below --
2008-02-12 23:32 Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.