[lm-sensors] Preparing patches for pca9552, ad5259, and bq27350

[lm-sensors] Preparing patches for pca9552, ad5259, and bq27350

[Matthew Bosworth]

Hi everyone,

   I've developed some i2c chip drivers that I'd like to contribute.   
They're working in our environment (Atmel at91 (ARM)  eval board), and  
I'm currently checking them against the kernel coding standards.

   Specifically, the chips are :

Phillips PCA9552 16-bit I2C-bus LED driver with programmable blink rates
Analog Devices AD5259 Nonvolatile, I2C-Compatible 256-Position,  
Digital Potentiometer
TI BQ27350  Single Cell Li-Ion Battery Manager With Impedance Track  
Fuel Gauge Technology

Feel free to put my name on the 'New Drivers' page, so no one else  
needs to start on them.

I have one question that I couldn't find in the docs anywhere.  When I  
provide a patch, what kernel revision / git repository should I be  
patching against?   I've been working in a Timesys 2.6.22.9 kernel but  
I'm happy to merge them with another repo and create patches from there.

Thanks!
-Matt Bosworth
matt at codetastic dot com

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] Preparing patches for pca9552, ad5259, and bq27350

[Jean Delvare]

Hi Matthew,

On Mon, 18 Feb 2008 10:54:55 -0800, Matthew Bosworth wrote:
> Hi everyone,
> 
>    I've developed some i2c chip drivers that I'd like to contribute.   
> They're working in our environment (Atmel at91 (ARM)  eval board), and  
> I'm currently checking them against the kernel coding standards.
> 
>    Specifically, the chips are :
> 
> Phillips PCA9552 16-bit I2C-bus LED driver with programmable blink rates
> Analog Devices AD5259 Nonvolatile, I2C-Compatible 256-Position,  
> Digital Potentiometer
> TI BQ27350  Single Cell Li-Ion Battery Manager With Impedance Track  
> Fuel Gauge Technology
> 
> Feel free to put my name on the 'New Drivers' page, so no one else  
> needs to start on them.
>
> I have one question that I couldn't find in the docs anywhere.  When I  
> provide a patch, what kernel revision / git repository should I be  
> patching against?   I've been working in a Timesys 2.6.22.9 kernel but  
> I'm happy to merge them with another repo and create patches from there.

These devices do not seem to have anything to do with hardware
monitoring, do they? If not, you're using the wrong mailing list, try
the i2c list instead.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] Preparing patches for pca9552, ad5259, and bq27350

[Matthew Bosworth]

Hi Jean,

   The BQ27350 is a battery monitor for Li-ion batteries, does that  
count?  I'll send mail to the i2c list about the other two.

Thanks!
-Matt

On Feb 18, 2008, at 11:45 AM, Jean Delvare wrote:

> Hi Matthew,
>
> On Mon, 18 Feb 2008 10:54:55 -0800, Matthew Bosworth wrote:
>> Hi everyone,
>>
>>   I've developed some i2c chip drivers that I'd like to contribute.
>> They're working in our environment (Atmel at91 (ARM)  eval board),  
>> and
>> I'm currently checking them against the kernel coding standards.
>>
>>   Specifically, the chips are :
>>
>> Phillips PCA9552 16-bit I2C-bus LED driver with programmable blink  
>> rates
>> Analog Devices AD5259 Nonvolatile, I2C-Compatible 256-Position,
>> Digital Potentiometer
>> TI BQ27350  Single Cell Li-Ion Battery Manager With Impedance Track
>> Fuel Gauge Technology
>>
>> Feel free to put my name on the 'New Drivers' page, so no one else
>> needs to start on them.
>>
>> I have one question that I couldn't find in the docs anywhere.   
>> When I
>> provide a patch, what kernel revision / git repository should I be
>> patching against?   I've been working in a Timesys 2.6.22.9 kernel  
>> but
>> I'm happy to merge them with another repo and create patches from  
>> there.
>
> These devices do not seem to have anything to do with hardware
> monitoring, do they? If not, you're using the wrong mailing list, try
> the i2c list instead.
>
> -- 
> Jean Delvare
>
> _______________________________________________
> lm-sensors mailing list
> lm-sensors@lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
>


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] Preparing patches for pca9552, ad5259, and bq27350

[Jean Delvare]

Hi Matthew,

On Mon, 18 Feb 2008 13:26:10 -0800, Matthew Bosworth wrote:
>    The BQ27350 is a battery monitor for Li-ion batteries, does that  
> count?  I'll send mail to the i2c list about the other two.

Does it implement any part of the standard hwmon interface? If not,
then it can't be considered a hwmon driver. FWIW, we do not have any
battery monitor driver in drivers/hwmon yet, and I am under the
impression that your driver would rather belong to drivers/power.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] Preparing patches for pca9552, ad5259, and bq27350

[Philip Pokorny]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

--===============0127598026573823253==
Content-class: urn:content-classes:message
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C872CC.4EA48B70"

This is a multi-part message in MIME format.

[-- Attachment #2: Type: text/plain, Size: 1161 bytes --]

There are several monitoring chips that monitor the CMOS battery voltage.  That's similar...

Phil P.

-- 
Philip Pokorny, RHCE
Director of Field Engineering 
Penguin Computing  http://www.penguincomputing.com

 -----Original Message-----
From: 	Jean Delvare [mailto:khali@linux-fr.org]
Sent:	Monday, February 18, 2008 01:43 PM Pacific Standard Time
To:	Matthew Bosworth
Cc:	lm-sensors@lm-sensors.org
Subject:	Re: [lm-sensors] Preparing patches for pca9552, ad5259, and bq27350

Hi Matthew,

On Mon, 18 Feb 2008 13:26:10 -0800, Matthew Bosworth wrote:
>    The BQ27350 is a battery monitor for Li-ion batteries, does that  
> count?  I'll send mail to the i2c list about the other two.

Does it implement any part of the standard hwmon interface? If not,
then it can't be considered a hwmon driver. FWIW, we do not have any
battery monitor driver in drivers/hwmon yet, and I am under the
impression that your driver would rather belong to drivers/power.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

[-- Attachment #3: Type: text/html, Size: 1865 bytes --]

Re: [lm-sensors] Preparing patches for pca9552, ad5259, and bq27350

[Jean Delvare]

On Mon, 18 Feb 2008 23:51:59 -0800, Philip Pokorny wrote:
> There are several monitoring chips that monitor the CMOS battery
> voltage.  That's similar...

While I agree that battery monitoring drivers and hardware monitoring
drivers have some features in common (in particular measuring an input
voltage) I still believe that having separate subsystems for these,
with different sysfs interfaces, makes sense. The user needs are
different. The CMOS battery monitoring is only there to tell you when
you should change the battery. A "real" battery monitor OTOH will tell
you a lot more information on the battery, how much energy there is
left inside, how much time you have before the power runs out, how old
the battery is, how hot it is, etc. Using the hwmon standard sysfs
interface for this would probably put restrictions on what can be done.
This doesn't mean though that battery drivers can't additionally export
their sensor values as standard, read-only hwmon sysfs values (maybe
even using common code for all battery drivers) but I don't think that
this should be their primary interface.

Anyway, I didn't look deep enough into the power subsystem to make
myself a definitive opinion, so the above is really only a first
thought. I might be wrong.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors