From: Ivo van Doorn <ivdoorn@gmail.com>
To: Sebastian Siewior <netdev@ml.breakpoint.cc>
Cc: Masakazu Mokuno <mokuno@sm.sony.co.jp>,
jgarzik@pobox.com, netdev@vger.kernel.org
Subject: Re: [PATCH] [PS3] gelic wireless driver needs MAC80211 support
Date: Sat, 23 Feb 2008 20:44:59 +0100 [thread overview]
Message-ID: <200802232044.59887.IvDoorn@gmail.com> (raw)
In-Reply-To: <20080223193517.GA6704@Chamillionaire.breakpoint.cc>
On Saturday 23 February 2008, Sebastian Siewior wrote:
> so select it.
> Signed-off-by: Sebastian Siewior <sebastian@breakpoint.cc>
> ---
> drivers/net/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index f337800..a116056 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2363,6 +2363,7 @@ config GELIC_NET
> config GELIC_WIRELESS
> bool "PS3 Wireless support"
> depends on GELIC_NET
> + select MAC80211
> help
> This option adds the support for the wireless feature of PS3.
> If you have the wireless-less model of PS3 or have no plan to
Is there any particular reason why this driver is in drivers/net instead
of drivers/net/wireless (along with all other wireless drivers?
Additionally, all other mac80211 drivers depend on mac80211 instead
of selecting it. So I think for consistency it might be better to also
make this driver depend on it, rather then selecting.
Ivo
next prev parent reply other threads:[~2008-02-23 19:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-23 19:35 [PATCH] [PS3] gelic wireless driver needs MAC80211 support Sebastian Siewior
2008-02-23 19:44 ` Ivo van Doorn [this message]
2008-02-23 19:50 ` Ivo van Doorn
2008-02-23 20:06 ` Sebastian Siewior
2008-02-23 20:09 ` Sebastian Siewior
2008-02-23 20:19 ` Ivo van Doorn
2008-02-23 20:09 ` Ivo van Doorn
2008-02-23 20:15 ` Sebastian Siewior
2008-02-23 20:19 ` Ivo van Doorn
2008-02-23 20:26 ` Jeff Garzik
2008-02-23 20:43 ` Sebastian Siewior
2008-02-25 10:13 ` Johannes Berg
2008-02-25 11:16 ` Sebastian Siewior
2008-02-25 11:38 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802232044.59887.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=jgarzik@pobox.com \
--cc=mokuno@sm.sony.co.jp \
--cc=netdev@ml.breakpoint.cc \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.