All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ivo van Doorn <ivdoorn@gmail.com>
To: Sebastian Siewior <bigeasy@breakpoint.cc>
Cc: Sebastian Siewior <netdev@ml.breakpoint.cc>,
	Masakazu Mokuno <mokuno@sm.sony.co.jp>,
	jgarzik@pobox.com, netdev@vger.kernel.org
Subject: Re: [PATCH] [PS3] gelic wireless driver needs MAC80211 support
Date: Sat, 23 Feb 2008 21:09:26 +0100	[thread overview]
Message-ID: <200802232109.27158.IvDoorn@gmail.com> (raw)
In-Reply-To: <20080223200637.GA7135@Chamillionaire.breakpoint.cc>

On Saturday 23 February 2008, Sebastian Siewior wrote:
> * Ivo van Doorn | 2008-02-23 20:50:34 [+0100]:
> 
> >Additionally, what part of the driver actually uses mac80211?
> >I just browsed to the code, and it seems to work completely without
> >using mac80211. Instead it seems to work directly by registering a
> >net_device structure...
>   CC      drivers/net/ps3_gelic_wireless.o
> /home/bigeasy/git/linux-2.6/drivers/net/ps3_gelic_wireless.c: In function 'gelic_wl_setup_netdev_ops':
> /home/bigeasy/git/linux-2.6/drivers/net/ps3_gelic_wireless.c:2660: error: 'struct net_device' has no member named 'wireless_data'
> /home/bigeasy/git/linux-2.6/drivers/net/ps3_gelic_wireless.c:2661: error: 'struct net_device' has no member named 'wireless_handlers'
> make[3]: *** [drivers/net/ps3_gelic_wireless.o] Error 1
> make[2]: *** [drivers/net] Error 2
> make[1]: *** [drivers] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [sub-make] Error 2
> 
> 
> I add this to the patch desctiption and post a depends on patach

Looking at include/linux/netdevice.h:

#ifdef CONFIG_WIRELESS_EXT
	/* List of functions to handle Wireless Extensions (instead of ioctl).
	 * See <net/iw_handler.h> for details. Jean II */
	const struct iw_handler_def *	wireless_handlers;
	/* Instance data managed by the core of Wireless Extensions. */
	struct iw_public_data *	wireless_data;
#endif

There is no dependency on mac80211 but on WIRELESS_EXT.
That is a config option most other drivers select, so you best change your patch to
	select WIRELESS_EXT
instead of MAC80211.

Ivo

  parent reply	other threads:[~2008-02-23 20:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-23 19:35 [PATCH] [PS3] gelic wireless driver needs MAC80211 support Sebastian Siewior
2008-02-23 19:44 ` Ivo van Doorn
2008-02-23 19:50   ` Ivo van Doorn
2008-02-23 20:06     ` Sebastian Siewior
2008-02-23 20:09       ` Sebastian Siewior
2008-02-23 20:19         ` Ivo van Doorn
2008-02-23 20:09       ` Ivo van Doorn [this message]
2008-02-23 20:15   ` Sebastian Siewior
2008-02-23 20:19     ` Ivo van Doorn
2008-02-23 20:26 ` Jeff Garzik
2008-02-23 20:43   ` Sebastian Siewior
2008-02-25 10:13   ` Johannes Berg
2008-02-25 11:16     ` Sebastian Siewior
2008-02-25 11:38       ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802232109.27158.IvDoorn@gmail.com \
    --to=ivdoorn@gmail.com \
    --cc=bigeasy@breakpoint.cc \
    --cc=jgarzik@pobox.com \
    --cc=mokuno@sm.sony.co.jp \
    --cc=netdev@ml.breakpoint.cc \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.