From: Jeff King <peff@peff.net>
To: Johannes Sixt <johannes.sixt@telecom.at>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Whit Armstrong <armstrong.whit@gmail.com>
Subject: Re: [PATCH 2/3] t3404: use configured shell instead of /bin/sh
Date: Sat, 23 Feb 2008 16:15:36 -0500 [thread overview]
Message-ID: <20080223211536.GA13280@coredump.intra.peff.net> (raw)
In-Reply-To: <200802232209.41428.johannes.sixt@telecom.at>
On Sat, Feb 23, 2008 at 10:09:41PM +0100, Johannes Sixt wrote:
> On Saturday 23 February 2008 21:34, Junio C Hamano wrote:
> > -echo "#!$SHELL" >fake-editor
> > +echo "#!$SHELL_PATH" >fake-editor.sh
>
> Hm, when we run the test outside make, like
>
> $ sh t3404-rebase-interactive.sh
>
> then the fake-editor.sh script begins with this line:
>
> #!
>
> Isn't this a trap similar to what Jeff wanted to avoid?
Well, the trap I wanted to avoid is that "/bin/sh" specifically is
broken. But yes, I think losing the ability to run the tests from the
commandline is bad.
Ideally we figured out a sane shell for our shell scripts in the main
build process, and we want to always use that here. I think "git
rev-parse --sane-shell-path" is probably overkill. Maybe test-lib.sh can
source a file of build-time options? The "diff -u" vs "cmp" thing could
go there, as well.
-Peff
next prev parent reply other threads:[~2008-02-23 21:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-20 23:59 [PATCH 0/3] solaris test results Jeff King
2008-02-21 0:00 ` [PATCH 1/3] git_config_*: don't assume we are parsing a config file Jeff King
2008-02-21 0:00 ` [PATCH 2/3] t3404: use configured shell instead of /bin/sh Jeff King
2008-02-23 20:13 ` Johannes Sixt
2008-02-23 20:26 ` Junio C Hamano
2008-02-23 20:34 ` Junio C Hamano
2008-02-23 21:09 ` Johannes Sixt
2008-02-23 21:15 ` Jeff King [this message]
2008-02-23 21:56 ` Junio C Hamano
2008-02-23 22:39 ` Jeff King
2008-02-23 22:46 ` Junio C Hamano
2008-02-23 22:49 ` Jeff King
2008-02-23 22:55 ` Junio C Hamano
2008-02-23 23:12 ` Jeff King
2008-02-24 0:03 ` Junio C Hamano
2008-02-24 19:40 ` Jeff King
2008-02-23 20:40 ` Jeff King
2008-02-23 20:50 ` Junio C Hamano
2008-02-23 21:12 ` Jeff King
2008-02-23 22:28 ` Jeff King
2008-02-23 22:35 ` Junio C Hamano
2008-02-23 22:44 ` Jeff King
2008-02-21 0:01 ` [PATCH 3/3] diff: fix java funcname pattern for solaris Jeff King
2008-02-21 0:34 ` [PATCH 0/3] solaris test results Junio C Hamano
2008-02-21 0:41 ` Jeff King
2008-02-22 5:26 ` Junio C Hamano
2008-02-22 5:29 ` Junio C Hamano
2008-02-22 5:42 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080223211536.GA13280@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=armstrong.whit@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.sixt@telecom.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.