From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Johannes Sixt <johannes.sixt@telecom.at>,
git@vger.kernel.org, Whit Armstrong <armstrong.whit@gmail.com>
Subject: Re: [PATCH 2/3] t3404: use configured shell instead of /bin/sh
Date: Sat, 23 Feb 2008 16:03:44 -0800 [thread overview]
Message-ID: <7vfxvjxlsv.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080223231253.GA14320@coredump.intra.peff.net> (Jeff King's message of "Sat, 23 Feb 2008 18:12:53 -0500")
Jeff King <peff@peff.net> writes:
> On Sat, Feb 23, 2008 at 02:55:42PM -0800, Junio C Hamano wrote:
>
>> I think the basic goal should be to come up with a way to make
>> sure that "cd t/ && make" and "cd t/ && sh -x tXXXX-name.sh"
>> would get an environment as close as possible to what happens
>> when you run "make test" at the toplevel.
>
> I was thinking of something like this:
> ...
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index 83889c4..3c4e21f 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -342,6 +342,8 @@ if ! test -x ../test-chmtime; then
> exit 1
> fi
>
> +. ../GIT-BUILD-OPTIONS
Sounds sane to me.
next prev parent reply other threads:[~2008-02-24 0:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-20 23:59 [PATCH 0/3] solaris test results Jeff King
2008-02-21 0:00 ` [PATCH 1/3] git_config_*: don't assume we are parsing a config file Jeff King
2008-02-21 0:00 ` [PATCH 2/3] t3404: use configured shell instead of /bin/sh Jeff King
2008-02-23 20:13 ` Johannes Sixt
2008-02-23 20:26 ` Junio C Hamano
2008-02-23 20:34 ` Junio C Hamano
2008-02-23 21:09 ` Johannes Sixt
2008-02-23 21:15 ` Jeff King
2008-02-23 21:56 ` Junio C Hamano
2008-02-23 22:39 ` Jeff King
2008-02-23 22:46 ` Junio C Hamano
2008-02-23 22:49 ` Jeff King
2008-02-23 22:55 ` Junio C Hamano
2008-02-23 23:12 ` Jeff King
2008-02-24 0:03 ` Junio C Hamano [this message]
2008-02-24 19:40 ` Jeff King
2008-02-23 20:40 ` Jeff King
2008-02-23 20:50 ` Junio C Hamano
2008-02-23 21:12 ` Jeff King
2008-02-23 22:28 ` Jeff King
2008-02-23 22:35 ` Junio C Hamano
2008-02-23 22:44 ` Jeff King
2008-02-21 0:01 ` [PATCH 3/3] diff: fix java funcname pattern for solaris Jeff King
2008-02-21 0:34 ` [PATCH 0/3] solaris test results Junio C Hamano
2008-02-21 0:41 ` Jeff King
2008-02-22 5:26 ` Junio C Hamano
2008-02-22 5:29 ` Junio C Hamano
2008-02-22 5:42 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vfxvjxlsv.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=armstrong.whit@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.sixt@telecom.at \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.