From: Paul Moore <paul.moore@hp.com>
To: James Morris <jmorris@namei.org>
Cc: Stephen Smalley <sds@tycho.nsa.gov>,
selinux@tycho.nsa.gov, Eric Paris <eparis@redhat.com>
Subject: Re: [PATCH][RFC] remove unused backpointers from security objects
Date: Mon, 25 Feb 2008 10:47:02 -0500 [thread overview]
Message-ID: <200802251047.02614.paul.moore@hp.com> (raw)
In-Reply-To: <Xine.LNX.4.64.0802260044410.24574@us.intercode.com.au>
On Monday 25 February 2008 8:47:15 am James Morris wrote:
> On Tue, 26 Feb 2008, James Morris wrote:
> > See updated version below, with the sk pointer (to allow the callee
> > to take the rcu read lock).
>
> Actually, we shouldn't need that lock there, and can directly call
> selinux_netlbl_sk_security_reset, right?
I'm looking at this right now ... based on the idea that you can safely
read/write 32-bit values without a lock I believe the locking for
sk_security_struct could use a bit of a tweak. I'm still
looking/thinking but I believe we can remove the rcu lock entirely and
just rework selinux_netlbl_inode_permission() a little bit.
If you can spare a few hours I'll post a RFC patch ...
--
paul moore
linux security @ hp
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2008-02-25 15:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-25 4:26 [PATCH][RFC] remove unused backpointers from security objects James Morris
2008-02-25 12:56 ` Stephen Smalley
2008-02-25 13:30 ` James Morris
2008-02-25 13:47 ` James Morris
2008-02-25 15:47 ` Paul Moore [this message]
2008-02-25 16:40 ` [PATCH] SELinux: Correct the NetLabel locking for the sk_security_struct Paul Moore
2008-02-25 16:42 ` Paul Moore
2008-02-25 21:29 ` Paul Moore
2008-02-25 22:28 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802251047.02614.paul.moore@hp.com \
--to=paul.moore@hp.com \
--cc=eparis@redhat.com \
--cc=jmorris@namei.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.