From: James Morris <jmorris@namei.org>
To: Paul Moore <paul.moore@hp.com>
Cc: sds@tycho.nsa.gov, eparis@redhat.com, selinux@tycho.nsa.gov
Subject: Re: [PATCH] SELinux: Correct the NetLabel locking for the sk_security_struct
Date: Tue, 26 Feb 2008 09:28:36 +1100 (EST) [thread overview]
Message-ID: <Xine.LNX.4.64.0802260924370.24764@us.intercode.com.au> (raw)
In-Reply-To: <20080225164033.31345.24622.stgit@flek.americas.hpqcorp.net>
On Mon, 25 Feb 2008, Paul Moore wrote:
> The RCU/spinlock locking approach for the nlbl_state in the sk_security_struct
> was almost certainly overkill. This patch removes both the RCU and spinlock
> locking, relying on the existing socket locks to handle the case of multiple
> writers. This change also makes several code reductions possible.
Ok, the other thing to be concerned with is instruction reordering, and
the possible need for memory barriers, which should be covered in this
case by the memory barriers provided by the existing socket locks.
I'll apply this to for-akpm and then a revised version of the backpointer
removal patch.
- James
--
James Morris
<jmorris@namei.org>
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
prev parent reply other threads:[~2008-02-25 22:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-25 4:26 [PATCH][RFC] remove unused backpointers from security objects James Morris
2008-02-25 12:56 ` Stephen Smalley
2008-02-25 13:30 ` James Morris
2008-02-25 13:47 ` James Morris
2008-02-25 15:47 ` Paul Moore
2008-02-25 16:40 ` [PATCH] SELinux: Correct the NetLabel locking for the sk_security_struct Paul Moore
2008-02-25 16:42 ` Paul Moore
2008-02-25 21:29 ` Paul Moore
2008-02-25 22:28 ` James Morris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Xine.LNX.4.64.0802260924370.24764@us.intercode.com.au \
--to=jmorris@namei.org \
--cc=eparis@redhat.com \
--cc=paul.moore@hp.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.