From: Andrew Morton <akpm@linux-foundation.org>
To: Jan Kara <jack@suse.cz>
Cc: Nix <nix@esperi.org.uk>, Peter Osterlund <petero2@telia.com>,
dm-devel@redhat.com, Jan Kara <jack@ucw.cz>,
linux-kernel@vger.kernel.org
Subject: Re: 2.6.24.2: 4KSTACKS + pcdrw + dm + mount -> stack overflow: ide-cd related? dm-related?
Date: Mon, 25 Feb 2008 14:51:56 -0800 [thread overview]
Message-ID: <20080225145156.4184b509.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080225224807.GA15700@atrey.karlin.mff.cuni.cz>
On Mon, 25 Feb 2008 23:48:07 +0100 Jan Kara <jack@suse.cz> wrote:
> > udf_process_sequence() seems to be another victim of gcc inlining.
> Hmm, I'll have a look what we can do.
noinline...
> > udf_add_entry() defines a couple of 256-byte local arrays.
> Yes, exactly two of them. One is non-trivial to get rid of - it's
> used for encoding of filename before we write it, but one is used during
> scanning of the directory whether the entry doesn't already exists (oh,
> my!) and we can just rip that off..
kmalloc is quite fast ;)
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Jan Kara <jack@suse.cz>
Cc: Nix <nix@esperi.org.uk>, Peter Osterlund <petero2@telia.com>,
linux-kernel@vger.kernel.org, dm-devel@redhat.com,
Jan Kara <jack@ucw.cz>
Subject: Re: 2.6.24.2: 4KSTACKS + pcdrw + dm + mount -> stack overflow: ide-cd related? dm-related?
Date: Mon, 25 Feb 2008 14:51:56 -0800 [thread overview]
Message-ID: <20080225145156.4184b509.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080225224807.GA15700@atrey.karlin.mff.cuni.cz>
On Mon, 25 Feb 2008 23:48:07 +0100 Jan Kara <jack@suse.cz> wrote:
> > udf_process_sequence() seems to be another victim of gcc inlining.
> Hmm, I'll have a look what we can do.
noinline...
> > udf_add_entry() defines a couple of 256-byte local arrays.
> Yes, exactly two of them. One is non-trivial to get rid of - it's
> used for encoding of filename before we write it, but one is used during
> scanning of the directory whether the entry doesn't already exists (oh,
> my!) and we can just rip that off..
kmalloc is quite fast ;)
next prev parent reply other threads:[~2008-02-25 22:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-24 1:56 2.6.24.2: 4KSTACKS + PCA403CD IDE CD + pcdrw + mount + PREEMPT -> stack overflow Nix
2008-02-24 15:59 ` 2.6.24.2: 4KSTACKS + pcdrw + dm + mount -> stack overflow: ide-cd related? dm-related? Nix
2008-02-24 16:56 ` Peter Osterlund
2008-02-24 17:02 ` Nix
2008-02-25 20:30 ` Andrew Morton
2008-02-25 20:30 ` Andrew Morton
2008-02-25 22:48 ` Jan Kara
2008-02-25 22:51 ` Andrew Morton [this message]
2008-02-25 22:51 ` Andrew Morton
2008-02-26 11:10 ` Jiri Kosina
2008-02-26 11:29 ` Ingo Molnar
2008-02-26 11:29 ` Ingo Molnar
2008-02-26 11:37 ` Jiri Kosina
2008-02-26 16:41 ` Jan Kara
2008-02-26 17:25 ` Daniel Hazelton
2008-03-06 16:14 ` Jan Kara
2008-03-10 20:09 ` Nix
2008-03-10 20:09 ` Nix
2008-02-25 20:25 ` Andrew Morton
2008-02-25 20:25 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080225145156.4184b509.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dm-devel@redhat.com \
--cc=jack@suse.cz \
--cc=jack@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=nix@esperi.org.uk \
--cc=petero2@telia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.