All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Copeland <me@bobcopeland.com>
To: bruno randolf <bruno@thinktube.com>
Cc: Nick Kossifidis <mickflemm@gmail.com>,
	ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
	linville@tuxdriver.com, jirislaby@gmail.com, mcgrof@gmail.com
Subject: Re: [ath5k-devel] [PATCH 6/8] ath5k: Fixes for PCI-E cards
Date: Mon, 25 Feb 2008 22:51:36 -0500	[thread overview]
Message-ID: <20080226035136.GA11064@hash.localnet> (raw)
In-Reply-To: <200802261113.34604.bruno@thinktube.com>

[-- Attachment #1: Type: text/plain, Size: 1677 bytes --]

On Tue, Feb 26, 2008 at 11:13:34AM +0900, bruno randolf wrote:
> so when is AR5K_PHY_AGCCTL_CAL getting cleared?

Actually in my trace I didn't see it resetting on its own.  The only
reads with _CAL == 0 happen right after a write that clears it.  
(See attached from grep "^[RW].*AGCCTL").  It would be nice if my
mmio trace had timing info...

On the other hand, it must happen or else ath5k_hw_reset would never
work on the 5424.

> the HAL enables noise floor calibration, and reads the result on then next 
> calibration interval, then enables calibration again and reads on the next... 
> i think that way it makes sure there is always enough time for the noise 
> floor calibration to take place in the mean time (the calibration can only 
> happen when the channel is otherwise silent).

Good to know.  I guess calibration timeouts could also be symptomatic of
general problems as well.  Incidentally, in my current session I've
disabled G mode from the capabilities set.  All is not well though, I'll
get a run of:

ath0: invalid Michael MIC in data frame from 00:1a:70:da:a9:cb
ath0: invalid Michael MIC in data frame from 00:1a:70:da:a9:cb
ath0: invalid Michael MIC in data frame from 00:1a:70:da:a9:cb
ath0: deauthenticate(reason=14)

(then it reassociates)

> another 20ms for the noise floor value to settle ( for (i = 20; i > 0; i--) 
> mdelay(1); ) that worked well for older chipsets, but also for 5424 this 
> results in more noise floor calibration timeouts.

Sounds plausible, though I didn't have a lot of success bumping up the
timeout there.  But then, I have no idea what I'm doing so I'll test any 
patches :)

-- 
Bob Copeland %% www.bobcopeland.com 

[-- Attachment #2: agc.txt --]
[-- Type: text/plain, Size: 5565 bytes --]

W: 0x9860 = 0x00009d18 - AR5K_PHY_AGCCTL                ................1..111.1...11... (ath_hal_reset)
R: 0x9860 = 0x00009d18 - AR5K_PHY_AGCCTL                ................1..111.1...11... (ath_hal_reset)
W: 0x9860 = 0x00009d1b - AR5K_PHY_AGCCTL                ................1..111.1...11.11 (ath_hal_reset)
R: 0x9860 = 0x00009d1b - AR5K_PHY_AGCCTL                ................1..111.1...11.11 (ath_hal_reset)
R: 0x9860 = 0x00009d1b - AR5K_PHY_AGCCTL                ................1..111.1...11.11 (ath_hal_reset)
R: 0x9860 = 0x00009d1b - AR5K_PHY_AGCCTL                ................1..111.1...11.11 (ath_hal_reset)
R: 0x9860 = 0x00009d1b - AR5K_PHY_AGCCTL                ................1..111.1...11.11 (ath_hal_reset)
R: 0x9860 = 0x00009d1b - AR5K_PHY_AGCCTL                ................1..111.1...11.11 (ath_hal_reset)
R: 0x9860 = 0x00009d1a - AR5K_PHY_AGCCTL                ................1..111.1...11.1. (ath_hal_reset)
W: 0x9860 = 0x00009d18 - AR5K_PHY_AGCCTL                ................1..111.1...11... (ath_hal_reset)
R: 0x9860 = 0x00009d18 - AR5K_PHY_AGCCTL                ................1..111.1...11... (ath_hal_reset)
W: 0x9860 = 0x00009d1b - AR5K_PHY_AGCCTL                ................1..111.1...11.11 (ath_hal_reset)
R: 0x9860 = 0x00009d1a - AR5K_PHY_AGCCTL                ................1..111.1...11.1. (ath_hal_reset)
W: 0x9860 = 0x00009d18 - AR5K_PHY_AGCCTL                ................1..111.1...11... (ath_hal_reset)
R: 0x9860 = 0x00009d18 - AR5K_PHY_AGCCTL                ................1..111.1...11... (ath_hal_reset)
W: 0x9860 = 0x00009d1b - AR5K_PHY_AGCCTL                ................1..111.1...11.11 (ath_hal_reset)
R: 0x9860 = 0x00009d1a - AR5K_PHY_AGCCTL                ................1..111.1...11.1. (ath_hal_reset)
W: 0x9860 = 0x00009d18 - AR5K_PHY_AGCCTL                ................1..111.1...11... (ath_hal_reset)
R: 0x9860 = 0x00009d18 - AR5K_PHY_AGCCTL                ................1..111.1...11... (ath_hal_reset)
W: 0x9860 = 0x00009d1b - AR5K_PHY_AGCCTL                ................1..111.1...11.11 (ath_hal_reset)
R: 0x9860 = 0x00009d1a - AR5K_PHY_AGCCTL                ................1..111.1...11.1. (ath_hal_reset)
W: 0x9860 = 0x00009d18 - AR5K_PHY_AGCCTL                ................1..111.1...11... (ath_hal_reset)
R: 0x9860 = 0x00009d18 - AR5K_PHY_AGCCTL                ................1..111.1...11... (ath_hal_reset)
W: 0x9860 = 0x00009d1b - AR5K_PHY_AGCCTL                ................1..111.1...11.11 (ath_hal_reset)
R: 0x9860 = 0x00009d1a - AR5K_PHY_AGCCTL                ................1..111.1...11.1. (ath_hal_reset)
W: 0x9860 = 0x00009d18 - AR5K_PHY_AGCCTL                ................1..111.1...11... (ath_hal_reset)
R: 0x9860 = 0x00009d18 - AR5K_PHY_AGCCTL                ................1..111.1...11... (ath_hal_reset)
W: 0x9860 = 0x00009d1b - AR5K_PHY_AGCCTL                ................1..111.1...11.11 (ath_hal_reset)
R: 0x9860 = 0x00009d1a - AR5K_PHY_AGCCTL                ................1..111.1...11.1. (ath_hal_reset)
W: 0x9860 = 0x00009d18 - AR5K_PHY_AGCCTL                ................1..111.1...11... (ath_hal_reset)
R: 0x9860 = 0x00009d18 - AR5K_PHY_AGCCTL                ................1..111.1...11... (ath_hal_reset)
W: 0x9860 = 0x00009d1b - AR5K_PHY_AGCCTL                ................1..111.1...11.11 (ath_hal_reset)
R: 0x9860 = 0x00009d1a - AR5K_PHY_AGCCTL                ................1..111.1...11.1. (ath_hal_reset)
W: 0x9860 = 0x00009d18 - AR5K_PHY_AGCCTL                ................1..111.1...11... (ath_hal_reset)
R: 0x9860 = 0x00009d18 - AR5K_PHY_AGCCTL                ................1..111.1...11... (ath_hal_reset)
W: 0x9860 = 0x00009d1b - AR5K_PHY_AGCCTL                ................1..111.1...11.11 (ath_hal_reset)
R: 0x9860 = 0x00009d1a - AR5K_PHY_AGCCTL                ................1..111.1...11.1. (ath_hal_reset)
W: 0x9860 = 0x00009d18 - AR5K_PHY_AGCCTL                ................1..111.1...11... (ath_hal_reset)
R: 0x9860 = 0x00009d18 - AR5K_PHY_AGCCTL                ................1..111.1...11... (ath_hal_reset)
W: 0x9860 = 0x00009d1b - AR5K_PHY_AGCCTL                ................1..111.1...11.11 (ath_hal_reset)
R: 0x9860 = 0x00009d1a - AR5K_PHY_AGCCTL                ................1..111.1...11.1. (ath_hal_reset)
W: 0x9860 = 0x00009d18 - AR5K_PHY_AGCCTL                ................1..111.1...11... (ath_hal_reset)
R: 0x9860 = 0x00009d18 - AR5K_PHY_AGCCTL                ................1..111.1...11... (ath_hal_reset)
W: 0x9860 = 0x00009d1b - AR5K_PHY_AGCCTL                ................1..111.1...11.11 (ath_hal_reset)
R: 0x9860 = 0x00009d1a - AR5K_PHY_AGCCTL                ................1..111.1...11.1. (ath_hal_reset)
W: 0x9860 = 0x00009d10 - AR5K_PHY_AGCCTL                ................1..111.1...1.... (ath_hal_reset)
R: 0x9860 = 0x00009d10 - AR5K_PHY_AGCCTL                ................1..111.1...1.... (ath_hal_reset)
W: 0x9860 = 0x00009d13 - AR5K_PHY_AGCCTL                ................1..111.1...1..11 (ath_hal_reset)
R: 0x9860 = 0x00009d12 - AR5K_PHY_AGCCTL                ................1..111.1...1..1. (ath_hal_reset)
W: 0x9860 = 0x00009d10 - AR5K_PHY_AGCCTL                ................1..111.1...1.... (ath_hal_reset)
R: 0x9860 = 0x00009d10 - AR5K_PHY_AGCCTL                ................1..111.1...1.... (ath_hal_reset)
W: 0x9860 = 0x00009d13 - AR5K_PHY_AGCCTL                ................1..111.1...1..11 (ath_hal_reset)
R: 0x9860 = 0x00009d12 - AR5K_PHY_AGCCTL                ................1..111.1...1..1. (ath_hal_reset)

  reply	other threads:[~2008-02-26  3:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-25 15:43 [ath5k-devel] [PATCH 6/8] ath5k: Fixes for PCI-E cards Bob Copeland
2008-02-26  2:13 ` bruno randolf
2008-02-26  3:51   ` Bob Copeland [this message]
2008-02-26  3:57   ` Nick Kossifidis
2008-02-26  4:39     ` Bob Copeland
  -- strict thread matches above, loose matches on Subject: below --
2008-02-24  4:28 Nick Kossifidis
2008-02-24  4:45 ` [ath5k-devel] " Nick Kossifidis
2008-02-24  4:47   ` Nick Kossifidis
2008-02-24 16:09   ` Bob Copeland
2008-02-24 17:59   ` Bob Copeland
2008-02-24 18:58     ` Nick Kossifidis
2008-02-24 20:21       ` Bob Copeland
2008-02-24 23:23         ` Nick Kossifidis
2008-02-27  3:23       ` Luis R. Rodriguez
2008-02-27  5:54         ` Nick Kossifidis
2008-02-27 13:30           ` Luis R. Rodriguez
2008-02-27 15:52             ` John W. Linville
2008-02-27 18:44               ` Nick Kossifidis
2008-02-28 22:20                 ` Luis R. Rodriguez
2008-02-24 23:48     ` Nick Kossifidis
2008-02-25  2:23       ` Bob Copeland
2008-02-25 14:20         ` Nick Kossifidis
2008-02-24 20:17   ` Christoph Hellwig
2008-02-24 23:27     ` Nick Kossifidis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080226035136.GA11064@hash.localnet \
    --to=me@bobcopeland.com \
    --cc=ath5k-devel@lists.ath5k.org \
    --cc=bruno@thinktube.com \
    --cc=jirislaby@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mcgrof@gmail.com \
    --cc=mickflemm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.