Re: Re: [PATCH] qemu vnc updates

["Daniel P. Berrange" <berrange@redhat.com>]

On Tue, Feb 26, 2008 at 10:15:51AM -0600, Anthony Liguori wrote:
> Stefano Stabellini wrote:
> >Hi all,
> >reading qemu code I realized that the qemu vnc server sometimes sends 
> >framebuffer updates even if the client didn't request any.
> >This is not consistent with the RFB protocol spec and can break some 
> >clients.
> 
> 
> It's actually consistent with the RFB spec.  Have you seen any clients 
> break?
> 
> The RFB spec states pretty clearly that a single 
> FramebufferUpdateRequest may generate 0 or more FramebufferUpdate 
> events.  Once a client has sent a single FramebufferUpdate request, it 
> should expect to continue to receive more FramebufferUpdates for an 
> indefinite period of time according to the specification.

The reverse is true too - the server may coallese multiple FramebufferUpdateRequest
into a single FramebufferUpdate reply. There is no 1-to-1 mapping between
request & reply as this patch attempts to enforce.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|