All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: xen-devel@lists.xensource.com,
	"Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: Re: [PATCH] qemu vnc updates
Date: Tue, 26 Feb 2008 17:56:12 +0000	[thread overview]
Message-ID: <47C452BC.2030100@eu.citrix.com> (raw)
In-Reply-To: <47C44C88.2010205@codemonkey.ws>

Anthony Liguori wrote:
> You mean realvnc?  The race condition is due to it's use of 
> SetPixelFormat.  By slowing the updates, what you're really doing is 
> just working around that race condition.  That's not a proper solution 
> though.
> 
> This goes away if you set the realvnc options so that it doesn't change 
> the pixel format from what the server specifies.
> 

I think that the realvnc "bug" is due to the fact that they assume that 
if they don't send any update requests, they shouldn't expect any.
This is not a wrong assumption to make unless you are right about the 1 
request -> N reply argument (I still think that this is not what the rfb 
spec says).
Besides my patch doesn't slow down the connection so much, I cannot tell 
the difference on a quick connections. I'll let you know what is the 
behaviour on a slow connection.

  reply	other threads:[~2008-02-26 17:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-26 11:24 [PATCH] qemu vnc updates Stefano Stabellini
2008-02-26 16:15 ` Anthony Liguori
2008-02-26 16:22   ` Daniel P. Berrange
2008-02-26 16:34     ` Stefano Stabellini
2008-02-26 17:29       ` Anthony Liguori
2008-02-26 17:56         ` Stefano Stabellini [this message]
2008-02-26 19:20           ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47C452BC.2030100@eu.citrix.com \
    --to=stefano.stabellini@eu.citrix.com \
    --cc=anthony@codemonkey.ws \
    --cc=berrange@redhat.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.