From: Andrew Morton <akpm@linux-foundation.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: kosaki.motohiro@jp.fujitsu.com, srostedt@redhat.com,
Lee.Schermerhorn@hp.com, linux-ia64@vger.kernel.org,
linux-kernel@vger.kernel.org, tony.luck@intel.com,
mingo@redhat.com, bob.picco@hp.com, eric.whitney@hp.com
Subject: Re: 2.6.25-rc2-mm1 - boot hangs on ia64
Date: Thu, 28 Feb 2008 19:24:23 +0000 [thread overview]
Message-ID: <20080228112423.fed6add2.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080228191214.GA17872@elte.hu>
On Thu, 28 Feb 2008 20:12:14 +0100
Ingo Molnar <mingo@elte.hu> wrote:
>
> * Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > On Thu, 28 Feb 2008 12:50:41 +0100 Ingo Molnar <mingo@elte.hu> wrote:
> >
> > > @@ -1000,7 +1001,7 @@ void release_console_sem(void)
> > > * If we try to wake up klogd while printing with the runqueue lock
> > > * held, this will deadlock.
> > > */
> > > - if (wake_klogd && !runqueue_is_locked())
> > > + if (wake_klogd)
> > > wake_up_klogd();
> > > }
> >
> > I don't think we shoudl have added that hack in the first place. It
> > solves a problem which about three developers hit four times in five
> > years but it has made kernel logging less reliable for everyone.
>
> well, the problem was ia64, not a problem on x86 or other platforms.
I am referring to the original change which made klogd wakeups unreliable.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: kosaki.motohiro@jp.fujitsu.com, srostedt@redhat.com,
Lee.Schermerhorn@hp.com, linux-ia64@vger.kernel.org,
linux-kernel@vger.kernel.org, tony.luck@intel.com,
mingo@redhat.com, bob.picco@hp.com, eric.whitney@hp.com
Subject: Re: 2.6.25-rc2-mm1 - boot hangs on ia64
Date: Thu, 28 Feb 2008 11:24:23 -0800 [thread overview]
Message-ID: <20080228112423.fed6add2.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080228191214.GA17872@elte.hu>
On Thu, 28 Feb 2008 20:12:14 +0100
Ingo Molnar <mingo@elte.hu> wrote:
>
> * Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > On Thu, 28 Feb 2008 12:50:41 +0100 Ingo Molnar <mingo@elte.hu> wrote:
> >
> > > @@ -1000,7 +1001,7 @@ void release_console_sem(void)
> > > * If we try to wake up klogd while printing with the runqueue lock
> > > * held, this will deadlock.
> > > */
> > > - if (wake_klogd && !runqueue_is_locked())
> > > + if (wake_klogd)
> > > wake_up_klogd();
> > > }
> >
> > I don't think we shoudl have added that hack in the first place. It
> > solves a problem which about three developers hit four times in five
> > years but it has made kernel logging less reliable for everyone.
>
> well, the problem was ia64, not a problem on x86 or other platforms.
I am referring to the original change which made klogd wakeups unreliable.
next prev parent reply other threads:[~2008-02-28 19:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-25 15:56 2.6.25-rc2-mm1 - boot hangs on ia64 Lee Schermerhorn
2008-02-25 15:56 ` Lee Schermerhorn
2008-02-26 11:25 ` KOSAKI Motohiro
2008-02-26 11:25 ` KOSAKI Motohiro
2008-02-26 11:31 ` Ingo Molnar
2008-02-26 11:31 ` Ingo Molnar
2008-02-27 1:42 ` KOSAKI Motohiro
2008-02-27 1:42 ` KOSAKI Motohiro
2008-02-27 7:11 ` Ingo Molnar
2008-02-27 7:11 ` Ingo Molnar
2008-02-28 10:38 ` KOSAKI Motohiro
2008-02-28 10:38 ` KOSAKI Motohiro
2008-02-28 11:50 ` Ingo Molnar
2008-02-28 11:50 ` Ingo Molnar
2008-02-28 12:13 ` KOSAKI Motohiro
2008-02-28 12:13 ` KOSAKI Motohiro
2008-02-28 18:13 ` Andrew Morton
2008-02-28 18:13 ` Andrew Morton
2008-02-28 19:12 ` Ingo Molnar
2008-02-28 19:12 ` Ingo Molnar
2008-02-28 19:24 ` Andrew Morton [this message]
2008-02-28 19:24 ` Andrew Morton
2008-02-28 19:32 ` Ingo Molnar
2008-02-28 19:32 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080228112423.fed6add2.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Lee.Schermerhorn@hp.com \
--cc=bob.picco@hp.com \
--cc=eric.whitney@hp.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=srostedt@redhat.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.