From: Jason Baron <jbaron@redhat.com>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: akpm@linux-foundation.org, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [patch 1/7] Immediate Values - Architecture Independent Code
Date: Thu, 28 Feb 2008 11:50:00 -0500 [thread overview]
Message-ID: <20080228165000.GA6856@redhat.com> (raw)
In-Reply-To: <20080227190519.GA14335@Krystal>
On Wed, Feb 27, 2008 at 02:05:19PM -0500, Mathieu Desnoyers wrote:
> > +struct stop_machine_data {
> > + int (*fn)(void *);
> > + void *data;
> > + struct completion done;
> > + int run_all;
> > +} smdata;
> > +
>
> Why do we now have to declare this static ? Can we pass it as a pointer
> to stopmachine instead ?
>
Since the other cpus need to access 'fn', i made smdata a global.
stop_machine_run() is system-wide, so we only need one of these...
thanks,
-Jason
next prev parent reply other threads:[~2008-02-28 16:51 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-02 21:08 [patch 0/7] Immediate Values Mathieu Desnoyers
2008-02-02 21:08 ` [patch 1/7] Immediate Values - Architecture Independent Code Mathieu Desnoyers
2008-02-26 22:52 ` Jason Baron
2008-02-26 23:12 ` Mathieu Desnoyers
2008-02-26 23:34 ` Mathieu Desnoyers
2008-02-27 16:44 ` Jason Baron
2008-02-27 17:01 ` Jason Baron
2008-02-27 19:05 ` Mathieu Desnoyers
2008-02-28 16:33 ` [patch 1/2] add ALL_CPUS option to stop_machine_run() Jason Baron
2008-02-28 22:09 ` Max Krasnyanskiy
2008-02-28 22:14 ` Mathieu Desnoyers
2008-02-29 2:39 ` Jason Baron
2008-02-29 9:00 ` Ingo Molnar
2008-02-29 18:24 ` Max Krasnyanskiy
2008-02-29 19:15 ` Ingo Molnar
2008-02-29 19:58 ` Max Krasnyanskiy
2008-03-03 4:12 ` Rusty Russell
2008-03-04 0:30 ` Max Krasnyanskiy
2008-03-04 2:36 ` Rusty Russell
2008-03-04 4:11 ` Max Krasnyansky
2008-03-02 23:32 ` Rusty Russell
2008-02-28 16:37 ` [patch 2/2] implement immediate updating via stop_machine_run() Jason Baron
2008-02-29 13:43 ` Mathieu Desnoyers
2008-02-28 16:50 ` Jason Baron [this message]
2008-02-02 21:08 ` [patch 2/7] Immediate Values - Kconfig menu in EMBEDDED Mathieu Desnoyers
2008-02-02 21:08 ` [patch 3/7] Immediate Values - x86 Optimization Mathieu Desnoyers
2008-02-02 21:08 ` [patch 4/7] Add text_poke and sync_core to powerpc Mathieu Desnoyers
2008-02-02 21:08 ` [patch 5/7] Immediate Values - Powerpc Optimization Mathieu Desnoyers
2008-02-02 21:08 ` [patch 6/7] Immediate Values - Documentation Mathieu Desnoyers
2008-02-02 21:08 ` [patch 7/7] Scheduler Profiling - Use Immediate Values Mathieu Desnoyers
-- strict thread matches above, loose matches on Subject: below --
2007-12-06 2:07 [patch 0/7] Immediate Values (redux) for 2.6.24-rc4-git3 Mathieu Desnoyers
2007-12-06 2:07 ` [patch 1/7] Immediate Values - Architecture Independent Code Mathieu Desnoyers
2007-09-18 21:07 [patch 0/7] Immediate Values for 2.6.23-rc6-mm1 Mathieu Desnoyers
2007-09-18 21:07 ` [patch 1/7] Immediate Values - Architecture Independent Code Mathieu Desnoyers
2007-09-17 18:42 [patch 0/7] Immediate Values Mathieu Desnoyers
2007-09-17 18:42 ` [patch 1/7] Immediate Values - Architecture Independent Code Mathieu Desnoyers
2007-09-18 17:47 ` Denys Vlasenko
2007-09-18 17:59 ` Mathieu Desnoyers
2007-09-18 20:01 ` Denys Vlasenko
2007-09-18 20:47 ` Mathieu Desnoyers
2007-09-19 8:45 ` Denys Vlasenko
2007-09-19 8:57 ` Denys Vlasenko
2007-09-19 11:27 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080228165000.GA6856@redhat.com \
--to=jbaron@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.