All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kyle McMartin <kyle@mcmartin.ca>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: linux-pci@atrey.karlin.mff.cuni.cz, linux-arch@vger.kernel.org,
	Russell King <rmk@arm.linux.org.uk>,
	linux-arm-kernel@lists.arm.linux.org.uk,
	Kyle McMartin <kyle@parisc-linux.org>,
	Matthew Wilcox <matthew@wil.cx>,
	Grant Grundler <grundler@parisc-linux.org>,
	linux-parisc@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@ozlabs.org, Chris Zankel <chris@zankel.net>
Subject: Re: [patch 5/6] PARISC: move PERR & SERR enables out of pcibios_enable_resources()
Date: Thu, 28 Feb 2008 12:38:16 -0500	[thread overview]
Message-ID: <20080228173816.GA32265@phobos.i.cabal.ca> (raw)
In-Reply-To: <20080228001053.209248743@ldl.fc.hp.com>

On Wed, Feb 27, 2008 at 05:04:42PM -0700, Bjorn Helgaas wrote:
> Move PERR and SERR enables from pcibios_enable_resources() to
> platform_pci_enable_device() so the former matches other
> architectures and can be shared.
> 

I don't have any problems with this, but I think the naming needs to
change. pcibios_* namespace should probably remain arch dependent.
Renaming the unified implementation to pci_enable_resources, and adding
a weak function pcibios_enable_resources that can be overridden by
parisc and arm to enable PERR/SERR after calling the generic
pci_enable_resources function. No?

regards, Kyle

WARNING: multiple messages have this Message-ID (diff)
From: Kyle McMartin <kyle@mcmartin.ca>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: linux-arch@vger.kernel.org, Chris Zankel <chris@zankel.net>,
	Grant Grundler <grundler@parisc-linux.org>,
	linux-parisc@vger.kernel.org, Matthew Wilcox <matthew@wil.cx>,
	Kyle McMartin <kyle@parisc-linux.org>,
	linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
	linux-pci@atrey.karlin.mff.cuni.cz,
	linux-arm-kernel@lists.arm.linux.org.uk,
	Russell King <rmk@arm.linux.org.uk>
Subject: Re: [patch 5/6] PARISC: move PERR & SERR enables out of pcibios_enable_resources()
Date: Thu, 28 Feb 2008 12:38:16 -0500	[thread overview]
Message-ID: <20080228173816.GA32265@phobos.i.cabal.ca> (raw)
In-Reply-To: <20080228001053.209248743@ldl.fc.hp.com>

On Wed, Feb 27, 2008 at 05:04:42PM -0700, Bjorn Helgaas wrote:
> Move PERR and SERR enables from pcibios_enable_resources() to
> platform_pci_enable_device() so the former matches other
> architectures and can be shared.
> 

I don't have any problems with this, but I think the naming needs to
change. pcibios_* namespace should probably remain arch dependent.
Renaming the unified implementation to pci_enable_resources, and adding
a weak function pcibios_enable_resources that can be overridden by
parisc and arm to enable PERR/SERR after calling the generic
pci_enable_resources function. No?

regards, Kyle

  parent reply	other threads:[~2008-02-28 17:38 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-28  0:04 [patch 0/6] RFC: PCI: consolidate pcibios_enable_resources() implementations, v2 Bjorn Helgaas
2008-02-28  0:04 ` Bjorn Helgaas
2008-02-28  0:04 ` [patch 1/6] PCI: split pcibios_enable_resources() out of pcibios_enable_device() Bjorn Helgaas
2008-02-28  0:04   ` Bjorn Helgaas
2008-02-28  0:04 ` [patch 2/6] ppc: make pcibios_enable_device() use pcibios_enable_resources() Bjorn Helgaas
2008-02-28  0:04   ` Bjorn Helgaas
2008-02-28  0:04 ` [patch 3/6] xtensa: " Bjorn Helgaas
2008-02-28  0:04   ` Bjorn Helgaas
2008-02-28  0:04 ` [patch 4/6] ARM: move bridge enable out of pcibios_enable_resources() Bjorn Helgaas
2008-02-28  0:04   ` Bjorn Helgaas
2008-03-03 17:59   ` Jesse Barnes
2008-03-03 17:59     ` Jesse Barnes
2008-03-03 20:35     ` Benjamin Herrenschmidt
2008-03-03 20:35       ` Benjamin Herrenschmidt
2008-03-03 20:43       ` Jesse Barnes
2008-03-03 20:43         ` Jesse Barnes
2008-03-06 15:06   ` Russell King - ARM Linux
2008-03-06 15:06     ` Russell King - ARM Linux
2008-03-06 15:06     ` Russell King - ARM Linux
     [not found]     ` <20080306150640.GL3283-f404yB8NqCZvn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2008-03-06 15:42       ` Bjorn Helgaas
2008-03-06 15:42         ` Bjorn Helgaas
2008-03-06 15:42         ` Bjorn Helgaas
2008-02-28  0:04 ` [patch 5/6] PARISC: move PERR & SERR enables " Bjorn Helgaas
2008-02-28  0:04   ` Bjorn Helgaas
2008-02-28 17:31   ` Grant Grundler
2008-02-28 17:31     ` Grant Grundler
2008-03-03 18:30     ` Jesse Barnes
2008-03-03 18:30       ` Jesse Barnes
2008-02-28 17:38   ` Kyle McMartin [this message]
2008-02-28 17:38     ` Kyle McMartin
2008-02-28  0:04 ` [patch 6/6] PCI: consolidate several pcibios_enable_resources() implementations Bjorn Helgaas
2008-02-28  0:04   ` Bjorn Helgaas
2008-02-28 17:55   ` David Howells
     [not found]   ` <20080228001053.404893334-e+Ta4ugHZmL3oGB3hsPCZA@public.gmane.org>
2008-03-03 18:45     ` Jesse Barnes
2008-03-03 18:45       ` Jesse Barnes
2008-03-03 18:45       ` Jesse Barnes
     [not found]       ` <200803031045.07054.jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>
2008-03-03 19:10         ` Bjorn Helgaas
2008-03-03 19:10           ` Bjorn Helgaas
2008-03-03 19:10           ` Bjorn Helgaas
     [not found] ` <20080228000437.880811124-e+Ta4ugHZmL3oGB3hsPCZA@public.gmane.org>
2008-03-03 19:44   ` [patch 0/6] RFC: PCI: consolidate pcibios_enable_resources() implementations, v2 Russell King
2008-03-03 19:44     ` Russell King
2008-03-03 19:44     ` Russell King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080228173816.GA32265@phobos.i.cabal.ca \
    --to=kyle@mcmartin.ca \
    --cc=benh@kernel.crashing.org \
    --cc=bjorn.helgaas@hp.com \
    --cc=chris@zankel.net \
    --cc=grundler@parisc-linux.org \
    --cc=kyle@parisc-linux.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=matthew@wil.cx \
    --cc=paulus@samba.org \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.