Re: [PATCH 2/2] ACPI: show temperature in millidegree Celsius

[Jean Delvare <khali@linux-fr.org>]

Hi Rui,

On Thu, 28 Feb 2008 07:51:30 +0800, Zhang, Rui wrote:
> 
> On Wed, 2008-02-27 at 18:13 +0800, Alexey Starikovskiy wrote:
> > Rui,
> > 
> > As I remember, ACPI returns temperature in 10ths of degree. If you are
> > going to report it in 1000ths of degree,
> > there is no reason to round them to degree.
> > 
> 
> Show the temperature in Millidegree Celsius.
> 
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> ---
>  drivers/acpi/thermal.c |   12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> Index: linux-2.6/drivers/acpi/thermal.c
> ===================================================================
> --- linux-2.6.orig/drivers/acpi/thermal.c
> +++ linux-2.6/drivers/acpi/thermal.c
> @@ -879,6 +879,8 @@ static void acpi_thermal_check(void *dat
>  }
>  
>  /* sys I/F for generic thermal sysfs support */
> +#define KELVIN_TO_MILLICELSIUS(t) (t * 100 - 273200)
> +
>  static int thermal_get_temp(struct thermal_zone_device *thermal, char *buf)
>  {
>  	struct acpi_thermal *tz = thermal->devdata;
> @@ -886,7 +888,7 @@ static int thermal_get_temp(struct therm
>  	if (!tz)
>  		return -EINVAL;
>  
> -	return sprintf(buf, "%ld\n", KELVIN_TO_CELSIUS(tz->temperature));
> +	return sprintf(buf, "%ld\n", KELVIN_TO_MILLICELSIUS(tz->temperature));
>  }
>  
>  static const char enabled[] = "kernel";
> @@ -980,21 +982,21 @@ static int thermal_get_trip_temp(struct 
>  
>  	if (tz->trips.critical.flags.valid) {
>  		if (!trip)
> -			return sprintf(buf, "%ld\n", KELVIN_TO_CELSIUS(
> +			return sprintf(buf, "%ld\n", KELVIN_TO_MILLICELSIUS(
>  				tz->trips.critical.temperature));
>  		trip--;
>  	}
>  
>  	if (tz->trips.hot.flags.valid) {
>  		if (!trip)
> -			return sprintf(buf, "%ld\n", KELVIN_TO_CELSIUS(
> +			return sprintf(buf, "%ld\n", KELVIN_TO_MILLICELSIUS(
>  					tz->trips.hot.temperature));
>  		trip--;
>  	}
>  
>  	if (tz->trips.passive.flags.valid) {
>  		if (!trip)
> -			return sprintf(buf, "%ld\n", KELVIN_TO_CELSIUS(
> +			return sprintf(buf, "%ld\n", KELVIN_TO_MILLICELSIUS(
>  					tz->trips.passive.temperature));
>  		trip--;
>  	}
> @@ -1002,7 +1004,7 @@ static int thermal_get_trip_temp(struct 
>  	for (i = 0; i < ACPI_THERMAL_MAX_ACTIVE &&
>  		tz->trips.active[i].flags.valid; i++) {
>  		if (!trip)
> -			return sprintf(buf, "%ld\n", KELVIN_TO_CELSIUS(
> +			return sprintf(buf, "%ld\n", KELVIN_TO_MILLICELSIUS(
>  					tz->trips.active[i].temperature));
>  		trip--;
>  	}

Yes, I like this one much better, thanks.

Acked-by: Jean Delvare <khali@linux-fr.org>

-- 
Jean Delvare