From: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-input@vger.kernel.org, magnus.damm@gmail.com,
lethal@linux-sh.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH 01/03] sh: SuperH KEYSC platform driver
Date: Fri, 29 Feb 2008 13:57:51 -0800 [thread overview]
Message-ID: <20080229135751.c94862be.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080229104856.22537.77214.sendpatchset@clockwork.opensource.se>
On Fri, 29 Feb 2008 19:48:56 +0900
Magnus Damm <magnus.damm@gmail.com> wrote:
> This patch adds a platform driver for the SuperH KEYSC block. The driver
> expects to get mode, timing information and keypad layout from the board
> code as platform data. The board code is resonsible for pin configuration.
>
> Both sh7343 and sh7722 should be supported, but only the sh7722 processor
> has been tested so far. SH_KEYSC_MODE_3 is yet to be tested.
>
> ...
>
> +#define res_size(res) ((res)->end - (res)->start + 1)
- buggy macro references its argument more than once
- could be implemented in C
- perhaps should be implemented in <linux/ioport.h>
> + input->phys = "sh-keysc-keys/input0";
Is the "/" in here safe? I trust we don't try to create a
sysfs/procfs/whatever file based off this string.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-input@vger.kernel.org, magnus.damm@gmail.com,
lethal@linux-sh.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH 01/03] sh: SuperH KEYSC platform driver
Date: Fri, 29 Feb 2008 21:57:51 +0000 [thread overview]
Message-ID: <20080229135751.c94862be.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080229104856.22537.77214.sendpatchset@clockwork.opensource.se>
On Fri, 29 Feb 2008 19:48:56 +0900
Magnus Damm <magnus.damm@gmail.com> wrote:
> This patch adds a platform driver for the SuperH KEYSC block. The driver
> expects to get mode, timing information and keypad layout from the board
> code as platform data. The board code is resonsible for pin configuration.
>
> Both sh7343 and sh7722 should be supported, but only the sh7722 processor
> has been tested so far. SH_KEYSC_MODE_3 is yet to be tested.
>
> ...
>
> +#define res_size(res) ((res)->end - (res)->start + 1)
- buggy macro references its argument more than once
- could be implemented in C
- perhaps should be implemented in <linux/ioport.h>
> + input->phys = "sh-keysc-keys/input0";
Is the "/" in here safe? I trust we don't try to create a
sysfs/procfs/whatever file based off this string.
next prev parent reply other threads:[~2008-02-29 21:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-29 10:48 [PATCH 00/03] sh: SuperH KEYSC keypad support Magnus Damm
2008-02-29 10:48 ` Magnus Damm
2008-02-29 10:48 ` [PATCH 01/03] sh: SuperH KEYSC platform driver Magnus Damm
2008-02-29 10:48 ` Magnus Damm
2008-02-29 21:57 ` Andrew Morton [this message]
2008-02-29 21:57 ` Andrew Morton
2008-02-29 10:49 ` [PATCH 02/03] sh: SuperH KEYSC keypad data for MigoR Magnus Damm
2008-02-29 10:49 ` Magnus Damm
2008-02-29 10:49 ` [PATCH 03/03] sh: SuperH KEYSC keypad data for Solution Engine 7722 Magnus Damm
2008-02-29 10:49 ` Magnus Damm
2008-02-29 22:01 ` [PATCH 00/03] sh: SuperH KEYSC keypad support Andrew Morton
2008-02-29 22:01 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080229135751.c94862be.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=lethal@linux-sh.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.