From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: dccp@vger.kernel.org
Subject: Re: [DCCP] [RFC]: Getting rid of unwieldy struct prefixes
Date: Fri, 29 Feb 2008 14:23:34 +0000 [thread overview]
Message-ID: <20080229142334.GL4306@ghostprotocols.net> (raw)
In-Reply-To: <20080229094518.GA12858@gerrit.erg.abdn.ac.uk>
Em Fri, Feb 29, 2008 at 09:45:18AM +0000, Gerrit Renker escreveu:
> [CCID-2]: Get rid of ccid2hc{tx,rx}_ prefixes
>
> Following discussion with Leandro yesterday, this is a request-for-comments
> patch to fix two problems caused by the ubiquitous long "hctx->ccid2htx_" and
> "hcrx->ccid2hcrx_" prefixes:
> -> code becomes hard to read;
> -> multiple-line statements are almost inevitable even for simple expressions;
> -> the prefixes are not really necessary - compare with "struct tcp_sock".
I haven't checked, is this over what is now on the test tree or on
upstream?
- Arnaldo
WARNING: multiple messages have this Message-ID (diff)
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Gerrit Renker <gerrit@erg.abdn.ac.uk>, Arnaldo <acme@redhat.com>,
dccp@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [DCCP] [RFC]: Getting rid of unwieldy struct prefixes
Date: Fri, 29 Feb 2008 11:23:34 -0300 [thread overview]
Message-ID: <20080229142334.GL4306@ghostprotocols.net> (raw)
In-Reply-To: <20080229094518.GA12858@gerrit.erg.abdn.ac.uk>
Em Fri, Feb 29, 2008 at 09:45:18AM +0000, Gerrit Renker escreveu:
> [CCID-2]: Get rid of ccid2hc{tx,rx}_ prefixes
>
> Following discussion with Leandro yesterday, this is a request-for-comments
> patch to fix two problems caused by the ubiquitous long "hctx->ccid2htx_" and
> "hcrx->ccid2hcrx_" prefixes:
> -> code becomes hard to read;
> -> multiple-line statements are almost inevitable even for simple expressions;
> -> the prefixes are not really necessary - compare with "struct tcp_sock".
I haven't checked, is this over what is now on the test tree or on
upstream?
- Arnaldo
next prev parent reply other threads:[~2008-02-29 14:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-29 9:45 [DCCP] [RFC]: Getting rid of unwieldy struct prefixes Gerrit Renker
2008-02-29 9:45 ` Gerrit Renker
2008-02-29 14:23 ` Arnaldo Carvalho de Melo [this message]
2008-02-29 14:23 ` Arnaldo Carvalho de Melo
2008-03-03 7:34 ` Gerrit Renker
2008-03-03 7:34 ` Gerrit Renker
2008-03-03 13:02 ` Arnaldo Carvalho de Melo
2008-03-03 13:02 ` Arnaldo Carvalho de Melo
2008-03-03 13:57 ` Gerrit Renker
2008-03-03 13:57 ` Gerrit Renker
2008-03-03 18:01 ` Leandro Sales
2008-03-03 18:01 ` Leandro Sales
-- strict thread matches above, loose matches on Subject: below --
2008-03-03 14:38 [DCCP] [CCID]: " Gerrit Renker
2008-03-03 14:38 ` Gerrit Renker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080229142334.GL4306@ghostprotocols.net \
--to=acme@redhat.com \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.