[PATCH] Fix typo in comment

[PATCH] Fix typo in comment

[Thiemo Seufer]

Fix a typo, we support now other page sizes as well.


Signed-off-by: Thiemo Seufer <ths@networkno.de>

Index: linux.git/arch/mips/mm/tlb-r4k.c
===================================================================
--- linux.git.orig/arch/mips/mm/tlb-r4k.c	2008-02-27 02:41:03.000000000 +0000
+++ linux.git/arch/mips/mm/tlb-r4k.c	2008-02-27 02:41:56.000000000 +0000
@@ -473,7 +473,7 @@
 	 *   - On R4600 1.7 the tlbp never hits for pages smaller than
 	 *     the value in the c0_pagemask register.
 	 *   - The entire mm handling assumes the c0_pagemask register to
-	 *     be set for 4kb pages.
+	 *     be set to fixed-size pages.
 	 */
 	probe_tlb(config);
 	write_c0_pagemask(PM_DEFAULT_MASK);

Re: [PATCH] Fix typo in comment

[Ralf Baechle]

On Fri, Feb 29, 2008 at 12:43:47AM +0000, Thiemo Seufer wrote:

Applied.  Thanks,

  Ralf

[PATCH] fix typo in comment

[Cristian Stoica]

Signed-off-by: Cristian Stoica <cristian.stoica@freescale.com>
---
 crypto/api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/api.c b/crypto/api.c
index 033a714..733e4ef 100644
--- a/crypto/api.c
+++ b/crypto/api.c
@@ -397,7 +397,7 @@ EXPORT_SYMBOL_GPL(__crypto_alloc_tfm);
  *	@mask: Mask for type comparison
  *
  *	This function should not be used by new algorithm types.
- *	Plesae use crypto_alloc_tfm instead.
+ *	Please use crypto_alloc_tfm instead.
  *
  *	crypto_alloc_base() will first attempt to locate an already loaded
  *	algorithm.  If that fails and the kernel supports dynamically loadable
-- 
1.8.1.5

[PATCH] Fix typo in comment.

[Matthias Lange]

Signed-off-by: Matthias Lange <matthias.lange@kernkonzept.com>
---
 drivers/mtd/nand/gpmi-nand/gpmi-lib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
index 141bd70..41f53ae 100644
--- a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
+++ b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
@@ -932,7 +932,7 @@ static int enable_edo_mode(struct gpmi_nand_data *this, int mode)
 
 	nand->select_chip(mtd, 0);
 
-	/* [1] send SET FEATURE commond to NAND */
+	/* [1] send SET FEATURE command to NAND */
 	feature[0] = mode;
 	ret = nand->onfi_set_features(mtd, nand,
 				ONFI_FEATURE_ADDR_TIMING_MODE, feature);
-- 
2.7.4

Re: [PATCH] Fix typo in comment.

[Boris Brezillon]

Hi Mattias,

On Tue, 30 May 2017 09:41:31 +0200
Matthias Lange <matthias.lange@kernkonzept.com> wrote:

Commit title should be prefixed with "mtd: nand: gpmi: ".

> Signed-off-by: Matthias Lange <matthias.lange@kernkonzept.com>
> ---
>  drivers/mtd/nand/gpmi-nand/gpmi-lib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
> index 141bd70..41f53ae 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
> @@ -932,7 +932,7 @@ static int enable_edo_mode(struct gpmi_nand_data *this, int mode)
>  
>  	nand->select_chip(mtd, 0);
>  
> -	/* [1] send SET FEATURE commond to NAND */
> +	/* [1] send SET FEATURE command to NAND */
>  	feature[0] = mode;
>  	ret = nand->onfi_set_features(mtd, nand,
>  				ONFI_FEATURE_ADDR_TIMING_MODE, feature);

Re: [PATCH] Fix typo in comment.

[Matthias Lange]

[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]

Hi Boris,

please consider the new version of the commit.

Best,
Matthias.


On 05/31/2017 11:22 AM, Boris Brezillon wrote:
> Hi Mattias,
> 
> On Tue, 30 May 2017 09:41:31 +0200
> Matthias Lange <matthias.lange@kernkonzept.com> wrote:
> 
> Commit title should be prefixed with "mtd: nand: gpmi: ".
> 
>> Signed-off-by: Matthias Lange <matthias.lange@kernkonzept.com>
>> ---
>>  drivers/mtd/nand/gpmi-nand/gpmi-lib.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
>> index 141bd70..41f53ae 100644
>> --- a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
>> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
>> @@ -932,7 +932,7 @@ static int enable_edo_mode(struct gpmi_nand_data *this, int mode)
>>  
>>  	nand->select_chip(mtd, 0);
>>  
>> -	/* [1] send SET FEATURE commond to NAND */
>> +	/* [1] send SET FEATURE command to NAND */
>>  	feature[0] = mode;
>>  	ret = nand->onfi_set_features(mtd, nand,
>>  				ONFI_FEATURE_ADDR_TIMING_MODE, feature);

[-- Attachment #2: 0001-mtd-nand-gpmi-fix-typo-in-comment.patch --]
[-- Type: text/x-patch, Size: 919 bytes --]

>From 09b2ba7b74617888376e1e8022b1e68d022473a9 Mon Sep 17 00:00:00 2001
From: Matthias Lange <matthias.lange@kernkonzept.com>
Date: Tue, 30 May 2017 09:35:03 +0200
Subject: [PATCH] mtd: nand: gpmi: fix typo in comment

Signed-off-by: Matthias Lange <matthias.lange@kernkonzept.com>
---
 drivers/mtd/nand/gpmi-nand/gpmi-lib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
index 141bd70..41f53ae 100644
--- a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
+++ b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
@@ -932,7 +932,7 @@ static int enable_edo_mode(struct gpmi_nand_data *this, int mode)
 
 	nand->select_chip(mtd, 0);
 
-	/* [1] send SET FEATURE commond to NAND */
+	/* [1] send SET FEATURE command to NAND */
 	feature[0] = mode;
 	ret = nand->onfi_set_features(mtd, nand,
 				ONFI_FEATURE_ADDR_TIMING_MODE, feature);
-- 
2.7.4

Re: [PATCH] Fix typo in comment.

[Boris Brezillon]

On Wed, 31 May 2017 17:07:54 +0200
Matthias Lange <matthias.lange@kernkonzept.com> wrote:

> Hi Boris,
> 
> please consider the new version of the commit.

Can you send the patch you've put in attachment using git send-email
and Cc all relevant maintainers?

> 
> Best,
> Matthias.
> 
> 
> On 05/31/2017 11:22 AM, Boris Brezillon wrote:
> > Hi Mattias,
> > 
> > On Tue, 30 May 2017 09:41:31 +0200
> > Matthias Lange <matthias.lange@kernkonzept.com> wrote:
> > 
> > Commit title should be prefixed with "mtd: nand: gpmi: ".
> >   
> >> Signed-off-by: Matthias Lange <matthias.lange@kernkonzept.com>
> >> ---
> >>  drivers/mtd/nand/gpmi-nand/gpmi-lib.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
> >> index 141bd70..41f53ae 100644
> >> --- a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
> >> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
> >> @@ -932,7 +932,7 @@ static int enable_edo_mode(struct gpmi_nand_data *this, int mode)
> >>  
> >>  	nand->select_chip(mtd, 0);
> >>  
> >> -	/* [1] send SET FEATURE commond to NAND */
> >> +	/* [1] send SET FEATURE command to NAND */
> >>  	feature[0] = mode;
> >>  	ret = nand->onfi_set_features(mtd, nand,
> >>  				ONFI_FEATURE_ADDR_TIMING_MODE, feature);  

[PATCH] Fix typo in comment.

[lagarcia]

From: Leonardo Garcia <lagarcia@br.ibm.com>

Signed-off-by: Leonardo Garcia <lagarcia@br.ibm.com>
---
 hw/virtio/vhost.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
index 28c7d78172..d6d290e79f 100644
--- a/hw/virtio/vhost.c
+++ b/hw/virtio/vhost.c
@@ -285,7 +285,7 @@ static int vhost_dev_has_iommu(struct vhost_dev *dev)
      * For vhost, VIRTIO_F_IOMMU_PLATFORM means the backend support
      * incremental memory mapping API via IOTLB API. For platform that
      * does not have IOMMU, there's no need to enable this feature
-     * which may cause unnecessary IOTLB miss/update trnasactions.
+     * which may cause unnecessary IOTLB miss/update transactions.
      */
     return vdev->dma_as != &address_space_memory &&
            virtio_host_has_feature(vdev, VIRTIO_F_IOMMU_PLATFORM);
-- 
2.29.2

Re: [PATCH] Fix typo in comment.

[Laurent Vivier]

Le 26/01/2021 à 19:26, lagarcia@linux.ibm.com a écrit :
> From: Leonardo Garcia <lagarcia@br.ibm.com>
> 
> Signed-off-by: Leonardo Garcia <lagarcia@br.ibm.com>
> ---
>  hw/virtio/vhost.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
> index 28c7d78172..d6d290e79f 100644
> --- a/hw/virtio/vhost.c
> +++ b/hw/virtio/vhost.c
> @@ -285,7 +285,7 @@ static int vhost_dev_has_iommu(struct vhost_dev *dev)
>       * For vhost, VIRTIO_F_IOMMU_PLATFORM means the backend support
>       * incremental memory mapping API via IOTLB API. For platform that
>       * does not have IOMMU, there's no need to enable this feature
> -     * which may cause unnecessary IOTLB miss/update trnasactions.
> +     * which may cause unnecessary IOTLB miss/update transactions.
>       */
>      return vdev->dma_as != &address_space_memory &&
>             virtio_host_has_feature(vdev, VIRTIO_F_IOMMU_PLATFORM);
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>

Please, re-send your patch to qemu-devel@nongnu.org, this is the reference list.

Thanks,
Laurent

Re: [PATCH] Fix typo in comment.

[Leonardo Augusto Guimarães Garcia]

On 1/29/21 05:00, Laurent Vivier wrote:
> Le 26/01/2021 à 19:26, lagarcia@linux.ibm.com a écrit :
>> From: Leonardo Garcia <lagarcia@br.ibm.com>
>>
>> Signed-off-by: Leonardo Garcia <lagarcia@br.ibm.com>
>> ---
>>  hw/virtio/vhost.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
>> index 28c7d78172..d6d290e79f 100644
>> --- a/hw/virtio/vhost.c
>> +++ b/hw/virtio/vhost.c
>> @@ -285,7 +285,7 @@ static int vhost_dev_has_iommu(struct vhost_dev *dev)
>>       * For vhost, VIRTIO_F_IOMMU_PLATFORM means the backend support
>>       * incremental memory mapping API via IOTLB API. For platform that
>>       * does not have IOMMU, there's no need to enable this feature
>> -     * which may cause unnecessary IOTLB miss/update trnasactions.
>> +     * which may cause unnecessary IOTLB miss/update transactions.
>>       */
>>      return vdev->dma_as != &address_space_memory &&
>>             virtio_host_has_feature(vdev, VIRTIO_F_IOMMU_PLATFORM);
>>
> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
>
> Please, re-send your patch to qemu-devel@nongnu.org, this is the reference list.


Thanks for the guidance. I'll do that now, as no one did that in the
past months. :)


Cheers,


Leo


>
> Thanks,
> Laurent