All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rick van Rein <rick@vanrein.org>
To: KOSAKI Motohiro <m-kosaki@ceres.dti.ne.jp>
Cc: Rick van Rein <rick@vanrein.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.24] mm: BadRAM support for broken memory
Date: Sun, 2 Mar 2008 17:42:35 +0000	[thread overview]
Message-ID: <20080302174235.GA26902@phantom.vanrein.org> (raw)
In-Reply-To: <2f11576a0803020901n715fda8esbfc0172f5a15ae3c@mail.gmail.com>

Hello Kosaki,

> in general,
> Agreed with we need bad memory treatness.

Glad to hear that.

> >  +#define PG_badram              20      /* BadRam page */
> 
> some architecture use PG_reserved for treat bad memory.
> Why do you want introduce new page flag?

It is clearer to properly name a flag, I suppose.
Is the use that you are mentioning the intended, and only use of the flag?
If not, I think it is clearer to use a separate flag instead of overloading
one.

> for show_mem() improvement?

For code clarity.


Thanks,
 -Rick

WARNING: multiple messages have this Message-ID (diff)
From: Rick van Rein <rick@vanrein.org>
To: KOSAKI Motohiro <m-kosaki@ceres.dti.ne.jp>
Cc: Rick van Rein <rick@vanrein.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.24] mm: BadRAM support for broken memory
Date: Sun, 2 Mar 2008 17:42:35 +0000	[thread overview]
Message-ID: <20080302174235.GA26902@phantom.vanrein.org> (raw)
In-Reply-To: <2f11576a0803020901n715fda8esbfc0172f5a15ae3c@mail.gmail.com>

Hello Kosaki,

> in general,
> Agreed with we need bad memory treatness.

Glad to hear that.

> >  +#define PG_badram              20      /* BadRam page */
> 
> some architecture use PG_reserved for treat bad memory.
> Why do you want introduce new page flag?

It is clearer to properly name a flag, I suppose.
Is the use that you are mentioning the intended, and only use of the flag?
If not, I think it is clearer to use a separate flag instead of overloading
one.

> for show_mem() improvement?

For code clarity.


Thanks,
 -Rick

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-03-02 17:42 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-02 13:42 [PATCH 2.6.24] mm: BadRAM support for broken memory Rick van Rein
2008-03-02 13:42 ` Rick van Rein
2008-03-02 17:01 ` KOSAKI Motohiro
2008-03-02 17:01   ` KOSAKI Motohiro
2008-03-02 17:42   ` Rick van Rein [this message]
2008-03-02 17:42     ` Rick van Rein
2008-03-03  3:21     ` KOSAKI Motohiro
2008-03-03  3:21       ` KOSAKI Motohiro
2008-03-03  5:32   ` Nick Piggin
2008-03-03  5:32     ` Nick Piggin
2008-03-03  7:14     ` KOSAKI Motohiro
2008-03-03  7:14       ` KOSAKI Motohiro
2008-03-03  7:35       ` Nick Piggin
2008-03-03  7:35         ` Nick Piggin
2008-03-03  9:49         ` KOSAKI Motohiro
2008-03-03  9:49           ` KOSAKI Motohiro
2008-03-03  9:58         ` KAMEZAWA Hiroyuki
2008-03-03  9:58           ` KAMEZAWA Hiroyuki
2008-03-02 17:53 ` Joseph Fannin
2008-03-02 19:34   ` Rick van Rein
2008-03-03 14:14 ` Pavel Machek
2008-03-03 16:41   ` KOSAKI Motohiro
2008-03-08 10:25     ` H. Peter Anvin
2008-03-08 10:30       ` H. Peter Anvin
2008-03-03 17:38 ` Randy Dunlap
2008-03-03 17:38   ` Randy Dunlap
     [not found] ` <20080303082238.GB13580@elte.hu>
     [not found]   ` <47CC3005.5090706@zytor.com>
     [not found]     ` <20080304133028.GC32383@elte.hu>
2008-03-04 16:29       ` H. Peter Anvin
2008-03-04 16:47         ` Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2008-03-04 12:21 devzero
2008-03-04 13:27 ` Ingo Molnar
2008-03-04 13:43   ` Rick van Rein
2008-03-04 14:06     ` Ingo Molnar
2008-03-04 15:05     ` Pavel Machek
2008-03-08 10:27   ` H. Peter Anvin
2008-03-08 11:13     ` Jiri Kosina
2008-03-10 10:12       ` Jan-Simon Möller
2008-03-10 11:24         ` Jan-Simon Möller
2008-03-10 11:52           ` Pavel Machek
2008-03-10 14:23             ` Jan-Simon Möller
2008-03-10 17:20               ` H. Peter Anvin
2008-03-10 17:48                 ` Jan-Simon Möller
2008-03-10 18:59                 ` Jan-Simon Möller
2008-03-10 19:16                   ` Jan-Simon Möller
2008-03-10 22:56                   ` Pavel Machek
2008-03-11  0:37                     ` Jan-Simon Möller
2008-03-11 17:23                   ` Len Brown
2008-03-11 17:49                     ` Jan-Simon Möller
2008-03-11 19:24                       ` Johannes Weiner
2008-03-11 20:00                         ` Jan-Simon Möller
2008-03-10 22:07                 ` Rick van Rein
2008-03-11  0:41                 ` Jan-Simon Möller
2008-03-11  6:41                   ` H. Peter Anvin
2008-03-04 14:00 devzero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080302174235.GA26902@phantom.vanrein.org \
    --to=rick@vanrein.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=m-kosaki@ceres.dti.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.