All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Cc: balbir@linux.vnet.ibm.com,
	Dhaval Giani <dhaval@linux.vnet.ibm.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Adrian Bunk <bunk@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
	Balbir Singh <balbir@in.ibm.com>
Subject: Re: 2.6.25-rc3-git3: Reported regressions from 2.6.24
Date: Wed, 5 Mar 2008 07:56:35 +0100	[thread overview]
Message-ID: <20080305065635.GC28398@elte.hu> (raw)
In-Reply-To: <1204694154.3248.194.camel@ymzhang>


* Zhang, Yanmin <yanmin_zhang@linux.intel.com> wrote:

> > Have you had a chance to git-bisect the culprit after the revert?
>
> How to bisect it if the reverted patch is submitted after the culprit 
> patch?

i do this by using quilt ontop of git-bisect.

I do something like this:

  mkdir patches
  echo revert.patch > patches/series
  git-log -1 -p 62fb185130e4d420f > patches/revert.patch 

  git-bisect start
  git-bisect  bad v2.6.24-rc3
  git-bisect good v2.6.24

  quilt push           # the revert is applied
  [ test the kernel ]
  quilt pop            # revert is unapplied

  git-bisect bad       # if it's still bad

  quilt push           # apply the revert again
  [ test the next kernel ]
  quilt pop            # undo the revert

  git-bisect good      # if it's good

etc. NOTE: if the "quilt push" fails, it's likely because you are in a 
point in the tree that does not have the reverted commits applied yet. 
In that case there's no need to push/pop, just test the bisection point.

Note, since there are _two_ guilty commits here:

      commit 58e2d4ca581167c2a079f4ee02be2f0bc52e8729
      Author: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
      Date:   Fri Jan 25 21:08:00 2008 +0100
      sched: group scheduling, change how cpu load is calculated

      commit 6b2d7700266b9402e12824e11e0099ae6a4a6a79
      Author: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
      Date:   Fri Jan 25 21:08:00 2008 +0100
      sched: group scheduler, fix fairness of cpu bandwidth allocation for task

make sure the bisection point is never "between" these two commits.

You can check whether a bisection point has the two guilty commits 
applied, via:

  git-log | grep -E '58e2d4ca581167c2a0|6b2d7700266b9402e12'

if this comes up empty, the guilty commits are not applied.

	Ingo

  parent reply	other threads:[~2008-03-05  6:57 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-03  2:16 2.6.25-rc3-git3: Reported regressions from 2.6.24 Rafael J. Wysocki
2008-03-03  7:53 ` Ingo Molnar
2008-03-03 11:41   ` Rafael J. Wysocki
2008-03-04  7:36 ` Pekka Enberg
2008-03-04 11:17 ` Pavel Machek
2008-03-04 13:59   ` Ingo Molnar
2008-03-04 23:00     ` Rafael J. Wysocki
2008-03-04 11:27 ` Dhaval Giani
2008-03-05  2:06   ` Zhang, Yanmin
2008-03-05  3:49     ` Balbir Singh
2008-03-05  5:15       ` Zhang, Yanmin
2008-03-05  6:36         ` Balbir Singh
2008-03-05  6:56         ` Ingo Molnar [this message]
2008-03-05  7:13           ` Zhang, Yanmin
2008-03-05  6:26     ` Zhang, Yanmin
2008-03-06  7:27 ` Ingo Molnar
2008-03-06 19:55   ` Guennadi Liakhovetski
2008-03-06 20:11     ` Andrew Morton
2008-03-06 20:51       ` Andrew Morton
2008-03-06 20:59         ` Ingo Molnar
2008-03-06 21:36           ` Andrew Morton
2008-03-06 22:57             ` Andrew Morton
2008-03-06 23:13               ` Suresh Siddha
2008-03-06 23:24                 ` Andrew Morton
2008-03-06 20:51     ` Greg KH
2008-03-06 17:57 ` Tilman Schmidt
2008-03-06 20:25   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080305065635.GC28398@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=balbir@in.ibm.com \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=bunk@kernel.org \
    --cc=dhaval@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=torvalds@linux-foundation.org \
    --cc=vatsa@linux.vnet.ibm.com \
    --cc=yanmin_zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.