Re: [PATCH] 2.6.25-rc3-mm1 - Mempolicy: make dequeue_huge_page_vma() obey MPOL_BIND nodemask

[Andrew Morton <akpm@linux-foundation.org>]

On Wed, 05 Mar 2008 11:06:34 -0500
Lee Schermerhorn <Lee.Schermerhorn@hp.com> wrote:

> Subject: [PATCH] 2.6.25-rc3-mm1 - Mempolicy:  make dequeue_huge_page_vma() obey MPOL_BIND nodemask

whine.

a) Please put the "2.6.25-rc3-mm1" stuff inside [].  This tells the
   receiver that this is not-to-be-included metadata pertaining only to
   this email.

b) Sometimes (quite often) people send me patches advertised as being
   for "2.6.x-mm-y" whereas they actually fix problems which are in
   mainline (or even -stable).

   So I tend to not believe it when people say that.

> Date: Wed, 05 Mar 2008 11:06:34 -0500
> Organization: HP/OSLO
> X-Mailer: Evolution 2.6.1 
> 
> PATCH Mempolicy - make dequeue_huge_page_vma() obey MPOL_BIND nodemask
> 
> dequeue_huge_page_vma() is not obeying the MPOL_BIND nodemask
> with the zonelist rework.  It needs to search only zones in 
> the mempolicy nodemask for hugepages.
> 
> Use for_each_zone_zonelist_nodemask() instead of
> for_each_zone_zonelist().
> 
> Note:  this will bloat mm/hugetlb.o a bit until Mel reworks the
> inlining of the for_each_zone... macros and helpers.
> 
> Added mempolicy helper function mpol_bind_nodemask() to hide
> the details of mempolicy from hugetlb and to avoid
> #ifdef CONFIG_NUMA in dequeue_huge_page_vma().
> 

But this patch does indeed fix an only-in-mm problem.  afacit it is a
bugfix against mm-filter-based-on-a-nodemask-as-well-as-a-gfp_mask.patch. 
At least, that's how I've staged it.

If you have already worked that information out, please let me know.

> Signed-off-by:  Lee Schermerhorn <lee.schermerhorn@hp.com>

You're "Lee", not " Lee" ;)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>