* + scsi-chc-fix-shadowed-variable-warnings-checkpatch-fixes.patch added to -mm tree
@ 2008-03-06 0:16 akpm
2008-03-06 0:27 ` James Bottomley
0 siblings, 1 reply; 3+ messages in thread
From: akpm @ 2008-03-06 0:16 UTC (permalink / raw)
To: mm-commits; +Cc: akpm, James.Bottomley, harvey.harrison
The patch titled
scsi-chc-fix-shadowed-variable-warnings-checkpatch-fixes
has been added to the -mm tree. Its filename is
scsi-chc-fix-shadowed-variable-warnings-checkpatch-fixes.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: scsi-chc-fix-shadowed-variable-warnings-checkpatch-fixes
From: Andrew Morton <akpm@linux-foundation.org>
ERROR: need space after that ',' (ctx:VxV)
#66: FILE: drivers/scsi/ch.c:742:
+ memset(ch_cmd,0,sizeof(ch_cmd));
^
ERROR: need space after that ',' (ctx:VxV)
#66: FILE: drivers/scsi/ch.c:742:
+ memset(ch_cmd,0,sizeof(ch_cmd));
^
ERROR: need space after that ',' (ctx:VxV)
#70: FILE: drivers/scsi/ch.c:746:
+ ch_elem_to_typecode(ch,elem);
^
total: 3 errors, 0 warnings, 55 lines checked
./patches/scsi-chc-fix-shadowed-variable-warnings.patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: Harvey Harrison <harvey.harrison@gmail.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/scsi/ch.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -puN drivers/scsi/ch.c~scsi-chc-fix-shadowed-variable-warnings-checkpatch-fixes drivers/scsi/ch.c
--- a/drivers/scsi/ch.c~scsi-chc-fix-shadowed-variable-warnings-checkpatch-fixes
+++ a/drivers/scsi/ch.c
@@ -739,11 +739,11 @@ static long ch_ioctl(struct file *file,
mutex_lock(&ch->lock);
voltag_retry:
- memset(ch_cmd,0,sizeof(ch_cmd));
+ memset(ch_cmd, 0, sizeof(ch_cmd));
ch_cmd[0] = READ_ELEMENT_STATUS;
ch_cmd[1] = (ch->device->lun << 5) |
(ch->voltags ? 0x10 : 0) |
- ch_elem_to_typecode(ch,elem);
+ ch_elem_to_typecode(ch, elem);
ch_cmd[2] = (elem >> 8) & 0xff;
ch_cmd[3] = elem & 0xff;
ch_cmd[5] = 1;
_
Patches currently in -mm which might be from akpm@linux-foundation.org are
git-x86.patch
arch-x86-kernel-ptracec-fix-defined-but-unused-warnings.patch
git-acpi-fixup.patch
acpi-enable-c3-power-state-on-dell-inspiron-8200.patch
git-alsa.patch
git-alsa-fix-git-conflicts.patch
git-powerpc-fix-git-rejects.patch
revert-gregkh-driver-video-add-the-go7007-driver.patch
driver-core-debug-for-bad-dev_attr_show-return-value.patch
git-drm.patch
git-dvb.patch
oz99x-i2c-button-and-led-support-driver.patch
git-hwmon.patch
git-hrt.patch
drivers-input-touchscreen-ads7846c-fix-uninitialized-var-warning.patch
maple-add-driver-for-sega-dreamcast-controller-update-checkpatch-fixes.patch
git-kvm.patch
pata-i-do-not-think-it-means-what-you-think-it-means.patch
git-md-accel.patch
git-md-accel-fix-git-rejects.patch
git-ubi.patch
update-smc91x-driver-with-arm-versatile-board-info.patch
git-nfsd.patch
git-ocfs2.patch
sh-export-copy-page-to-modules.patch
scsi-aic94xx-cleanups.patch
scsi-chc-fix-shadowed-variable-warnings-checkpatch-fixes.patch
git-block-git-rejects.patch
git-unionfs.patch
drivers-usb-storage-sddr55c-fix-uninitialized-var-warnings.patch
git-v9fs.patch
git-semaphore-git-rejects.patch
remove-sparse-warning-for-mmzoneh-checkpatch-fixes.patch
fix-invalidate_inode_pages2_range-to-not-clear-ret-checkpatch-fixes.patch
vmscan-give-referenced-active-and-unmapped-pages-a-second-trip-around-the-lru.patch
vm-dont-run-touch_buffer-during-buffercache-lookups.patch
capabilities-implement-per-process-securebits-warning-fix.patch
lsm-introduce-inode_getsecid-and-ipc_getsecid-hooks-checkpatch-fixes.patch
lsm-audit-introduce-generic-audit-lsm-hooks-checkpatch-fixes.patch
selinux-use-new-audit-hooks-remove-redundant-exports-checkpatch-fixes.patch
audit-final-renamings-and-cleanup-checkpatch-fixes.patch
make-dev-kmem-a-config-option-fix.patch
misc-phantom-add-compat-ioctl-checkpatch-fixes.patch
kernel-add-clamp-and-clamp_t-macros-checkpatch-fixes.patch
kernel-add-clamp-and-clamp_t-macros-fix.patch
r-o-bind-mounts-elevate-write-count-for-callers-of-vfs_mkdir-fix.patch
r-o-bind-mounts-elevate-write-count-for-xattr_permission-callers-fix.patch
r-o-bind-mounts-get-write-access-for-vfs_rename-callers-fix.patch
r-o-bind-mounts-check-mnt-instead-of-superblock-directly-fix.patch
r-o-bind-mounts-check-mnt-instead-of-superblock-directly-fix-2.patch
r-o-bind-mounts-get-callers-of-vfs_mknod-create-fix.patch
fs-inodec-use-hlist_for_each_entry-checkpatch-fixes.patch
add-rcu_assign_index-if-ever-needed-fix.patch
oprofile-change-cpu_buffer-from-array-to-per_cpu-variable-checkpatch-fixes.patch
vt-notifier-extension-for-accessibility-checkpatch-fixes.patch
kprobes-prevent-probing-of-preempt_schedule-fix.patch
kprobes-prevent-probing-of-preempt_schedule-checkpatch-fixes.patch
rtc-isl1208-new-style-conversion-and-minor-bug-fixes-checkpatch-fixes.patch
rtc-pcf8563-new-style-conversion-checkpatch-fixes.patch
rtc-pcf8563-new-style-conversion-checkpatch-fixes-fix.patch
rtc-x1205-new-style-conversion-checkpatch-fixes.patch
fb-add-support-for-foreign-endianness-force-it-on.patch
fbcon-replace-mono_col-macro-with-static-inline-fix.patch
fat_valid_media-remove-pointless-test.patch
cgroup-api-files-update-cpusets-to-use-cgroup-structured-file-api-fix.patch
workqueues-shrink-cpu_populated_map-when-cpu-dies-fix.patch
ext4-is-broken.patch
ipc-use-ipc_buildid-directly-from-ipc_addid-cleanup.patch
ipmi-run-to-completion-fixes-checkpatch-fixes.patch
ipmi-style-fixes-in-the-system-interface-code-checkpatch-fixes.patch
elf-fix-shadowed-variables-in-fs-binfmt_elfc.patch
sgi-altix-mmtimer-allow-larger-number-of-timers-per-node-fix.patch
sgi-altix-mmtimer-allow-larger-number-of-timers-per-node-fix-2.patch
epcac-static-functions-and-integer-as-null-pointer-fixes-checkpatch-fixes.patch
keys-add-keyctl-function-to-get-a-security-label-fix.patch
procfs-task-exe-symlink-fix.patch
edd-add-default-mode-config_edd_off=n-override-with-edd=onoff-fix.patch
mm-bdi-export-bdi-attributes-in-sysfs-ia64-fix.patch
basic-braille-screen-reader-support-ppc-fix.patch
security-replace-remaining-__function__-occurences-checkpatch-fixes.patch
reiser4.patch
jens-broke-reiser4patch-added-to-mm-tree.patch
page-owner-tracking-leak-detector.patch
nr_blockdev_pages-in_interrupt-warning.patch
slab-leaks3-default-y.patch
profile-likely-unlikely-macros.patch
profile-likely-unlikely-macros-fix.patch
put_bh-debug.patch
shrink_slab-handle-bad-shrinkers.patch
getblk-handle-2tb-devices.patch
getblk-handle-2tb-devices-fix.patch
undeprecate-pci_find_device.patch
w1-build-fix.patch
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: + scsi-chc-fix-shadowed-variable-warnings-checkpatch-fixes.patch added to -mm tree
2008-03-06 0:16 + scsi-chc-fix-shadowed-variable-warnings-checkpatch-fixes.patch added to -mm tree akpm
@ 2008-03-06 0:27 ` James Bottomley
2008-03-06 0:47 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: James Bottomley @ 2008-03-06 0:27 UTC (permalink / raw)
To: akpm; +Cc: linux-scsi, harvey.harrison
On Wed, 2008-03-05 at 16:16 -0800, akpm@linux-foundation.org wrote:
> The patch titled
> scsi-chc-fix-shadowed-variable-warnings-checkpatch-fixes
> has been added to the -mm tree. Its filename is
> scsi-chc-fix-shadowed-variable-warnings-checkpatch-fixes.patch
>
> Before you just go and hit "reply", please:
> a) Consider who else should be cc'ed
> b) Prefer to cc a suitable mailing list as well
> c) Ideally: find the original patch on the mailing list and do a
> reply-to-all to that, adding suitable additional cc's
>
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>
> See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
> out what to do about this
>
> The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
>
> ------------------------------------------------------
> Subject: scsi-chc-fix-shadowed-variable-warnings-checkpatch-fixes
> From: Andrew Morton <akpm@linux-foundation.org>
>
> ERROR: need space after that ',' (ctx:VxV)
> #66: FILE: drivers/scsi/ch.c:742:
> + memset(ch_cmd,0,sizeof(ch_cmd));
> ^
>
> ERROR: need space after that ',' (ctx:VxV)
> #66: FILE: drivers/scsi/ch.c:742:
> + memset(ch_cmd,0,sizeof(ch_cmd));
> ^
>
> ERROR: need space after that ',' (ctx:VxV)
> #70: FILE: drivers/scsi/ch.c:746:
> + ch_elem_to_typecode(ch,elem);
> ^
>
> total: 3 errors, 0 warnings, 55 lines checked
>
> ./patches/scsi-chc-fix-shadowed-variable-warnings.patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> Please run checkpatch prior to sending patches
>
> Cc: Harvey Harrison <harvey.harrison@gmail.com>
> Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/scsi/ch.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff -puN drivers/scsi/ch.c~scsi-chc-fix-shadowed-variable-warnings-checkpatch-fixes drivers/scsi/ch.c
> --- a/drivers/scsi/ch.c~scsi-chc-fix-shadowed-variable-warnings-checkpatch-fixes
> +++ a/drivers/scsi/ch.c
> @@ -739,11 +739,11 @@ static long ch_ioctl(struct file *file,
> mutex_lock(&ch->lock);
>
> voltag_retry:
> - memset(ch_cmd,0,sizeof(ch_cmd));
> + memset(ch_cmd, 0, sizeof(ch_cmd));
> ch_cmd[0] = READ_ELEMENT_STATUS;
> ch_cmd[1] = (ch->device->lun << 5) |
> (ch->voltags ? 0x10 : 0) |
> - ch_elem_to_typecode(ch,elem);
> + ch_elem_to_typecode(ch, elem);
> ch_cmd[2] = (elem >> 8) & 0xff;
> ch_cmd[3] = elem & 0xff;
> ch_cmd[5] = 1;
Please stop. I'm not taking whitespace patches ... one per file no
less. I take whitespace and other cleanups as part of real driver
updates only.
James
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: + scsi-chc-fix-shadowed-variable-warnings-checkpatch-fixes.patch added to -mm tree
2008-03-06 0:27 ` James Bottomley
@ 2008-03-06 0:47 ` Andrew Morton
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2008-03-06 0:47 UTC (permalink / raw)
To: James Bottomley; +Cc: linux-scsi, harvey.harrison
On Wed, 05 Mar 2008 18:27:27 -0600
James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> >
> > diff -puN drivers/scsi/ch.c~scsi-chc-fix-shadowed-variable-warnings-checkpatch-fixes drivers/scsi/ch.c
> > --- a/drivers/scsi/ch.c~scsi-chc-fix-shadowed-variable-warnings-checkpatch-fixes
> > +++ a/drivers/scsi/ch.c
> > @@ -739,11 +739,11 @@ static long ch_ioctl(struct file *file,
> > mutex_lock(&ch->lock);
> >
> > voltag_retry:
> > - memset(ch_cmd,0,sizeof(ch_cmd));
> > + memset(ch_cmd, 0, sizeof(ch_cmd));
> > ch_cmd[0] = READ_ELEMENT_STATUS;
> > ch_cmd[1] = (ch->device->lun << 5) |
> > (ch->voltags ? 0x10 : 0) |
> > - ch_elem_to_typecode(ch,elem);
> > + ch_elem_to_typecode(ch, elem);
> > ch_cmd[2] = (elem >> 8) & 0xff;
> > ch_cmd[3] = elem & 0xff;
> > ch_cmd[5] = 1;
>
> Please stop. I'm not taking whitespace patches ... one per file no
> less.
This gets folded into the base patch - there is no incremental effect.
> I take whitespace and other cleanups as part of real driver
> updates only.
That's what this does.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-03-06 0:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-06 0:16 + scsi-chc-fix-shadowed-variable-warnings-checkpatch-fixes.patch added to -mm tree akpm
2008-03-06 0:27 ` James Bottomley
2008-03-06 0:47 ` Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.