From: Ingo Molnar <mingo@elte.hu>
To: "Yang, Sheng" <sheng.yang@intel.com>
Cc: kvm-devel@lists.sourceforge.net, Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH 1/6] KVM: In kernel pit model
Date: Thu, 6 Mar 2008 13:33:16 +0100 [thread overview]
Message-ID: <20080306123316.GC20173@elte.hu> (raw)
In-Reply-To: <200803061725.53619.sheng.yang@intel.com>
* Yang, Sheng <sheng.yang@intel.com> wrote:
> > another silly style nit, the canonical comment style is:
> > > + /*
> > > + * Though spec said the state of 8254 is undefined after power-up,
> > > + * seems some tricky OS like Windows XP depends on IRQ0 interrupt
> > > + * when booting up.
> > > + * So here setting initialize rate for it, and not a specific number
> > > + */
> >
> > we are standardizing on that in other areas of arch/x86 and KVM uses
> > that too.
>
> ... Seems I still can't fully depend on script/checkpatch.pl to
> correct my coding style error...
yeah - checkpatch.pl tries to err on the side of caution, so that it can
be used in automated setups. (And your patch was pretty clean already so
this was mostly a sidenote.)
Ingo
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-03-06 12:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 10:22 [PATCH 1/6] KVM: In kernel pit model Yang, Sheng
2008-03-05 6:54 ` Avi Kivity
2008-03-05 7:04 ` Yang, Sheng
2008-03-05 9:15 ` Ingo Molnar
2008-03-05 11:35 ` Yang, Sheng
2008-03-05 11:43 ` Avi Kivity
2008-03-05 12:24 ` Ingo Molnar
2008-03-06 7:56 ` Yang, Sheng
2008-03-06 8:06 ` Avi Kivity
2008-03-06 8:43 ` Yang, Sheng
2008-03-06 9:41 ` Yang, Sheng
2008-03-07 8:12 ` Yang, Sheng
2008-03-07 8:53 ` Avi Kivity
2008-03-07 9:14 ` Yang, Sheng
2008-03-07 9:57 ` Avi Kivity
2008-03-06 9:14 ` Ingo Molnar
2008-03-06 9:25 ` Yang, Sheng
2008-03-06 12:33 ` Ingo Molnar [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-03-07 12:52 [PATCH 1/6] KVM: In kernel PIT model Yang, Sheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080306123316.GC20173@elte.hu \
--to=mingo@elte.hu \
--cc=avi@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=sheng.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.