From: Avi Kivity <avi@qumranet.com>
To: "Yang, Sheng" <sheng.yang@intel.com>
Cc: kvm-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/6] KVM: In kernel pit model
Date: Wed, 05 Mar 2008 13:43:43 +0200 [thread overview]
Message-ID: <47CE876F.7040901@qumranet.com> (raw)
In-Reply-To: <200803051935.40229.sheng.yang@intel.com>
Yang, Sheng wrote:
> Thanks for comments!
>
> On Wednesday 05 March 2008 17:15:29 Ingo Molnar wrote:
>
>> * Yang, Sheng <sheng.yang@intel.com> wrote:
>>
>>> +#if 1
>>> +#define pit_debug(fmt, arg...) printk(KERN_WARNING fmt, ##arg)
>>> +#else
>>> +#define pit_debug(fmt, arg...)
>>> +#endif
>>>
>> this should use pr_debug() instead i guess.
>>
>
> Um... I followed example on ./virt/kvm/ioapic.c here. Though I think it's good
> to substitute all self defined debug printk with pr_debug, why KVM have
> little pr_xxx(the only ones are in x86.c)? Maybe for KVM is acting more like
> a separate driver, and using printk is easier for separate debug? I really
> don't know...
>
>
It's mostly due to lack of knowledge about pr_debug(); it wasn't
intentional.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-03-05 11:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 10:22 [PATCH 1/6] KVM: In kernel pit model Yang, Sheng
2008-03-05 6:54 ` Avi Kivity
2008-03-05 7:04 ` Yang, Sheng
2008-03-05 9:15 ` Ingo Molnar
2008-03-05 11:35 ` Yang, Sheng
2008-03-05 11:43 ` Avi Kivity [this message]
2008-03-05 12:24 ` Ingo Molnar
2008-03-06 7:56 ` Yang, Sheng
2008-03-06 8:06 ` Avi Kivity
2008-03-06 8:43 ` Yang, Sheng
2008-03-06 9:41 ` Yang, Sheng
2008-03-07 8:12 ` Yang, Sheng
2008-03-07 8:53 ` Avi Kivity
2008-03-07 9:14 ` Yang, Sheng
2008-03-07 9:57 ` Avi Kivity
2008-03-06 9:14 ` Ingo Molnar
2008-03-06 9:25 ` Yang, Sheng
2008-03-06 12:33 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2008-03-07 12:52 [PATCH 1/6] KVM: In kernel PIT model Yang, Sheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47CE876F.7040901@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=sheng.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.