From: Al Viro <viro@ZenIV.linux.org.uk>
To: Roland Dreier <rdreier@cisco.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Davide Libenzi <davidel@xmailserver.org>,
Avi Kivity <avi@qumranet.com>,
kvm-devel@lists.sourceforge.net, akpm@linux-foundation.org
Subject: Re: [PATCH/RFC 1/2] anon-inodes: Remove fd_install() from anon_inode_getfd()
Date: Thu, 6 Mar 2008 15:14:30 +0000 [thread overview]
Message-ID: <20080306151430.GD27894@ZenIV.linux.org.uk> (raw)
In-Reply-To: <adak5kqyzv1.fsf@cisco.com>
On Wed, Feb 27, 2008 at 11:16:02AM -0800, Roland Dreier wrote:
> The anonymous inodes interface anon_inode_getfd() calls fd_install()
> for the newly created fd, which does not work for some use cases where
> the caller must do futher initialization before exposing the file to
> userspace. This is also probably not the safest interface, since the
> caller must be sure that it is OK if userspace closes the fd before
> anon_inode_getfd() even returns.
IMO that's a bad idea - majority of callers only care about fd and burdening
them with fd_install() is simply wrong. Separate helper function...
prev parent reply other threads:[~2008-03-06 15:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-25 19:10 [PATCH] uverbs: kill last remaining modular get_empty_filp user Christoph Hellwig
2008-02-27 19:01 ` Roland Dreier
2008-02-27 19:16 ` [PATCH/RFC 1/2] anon-inodes: Remove fd_install() from anon_inode_getfd() Roland Dreier
2008-02-27 19:16 ` Roland Dreier
2008-02-27 19:18 ` [PATCH 2/2] IB/uverbs: Use anonymous inodes instead of private filesystem Roland Dreier
2008-02-27 19:20 ` [PATCH/RFC 1/2] anon-inodes: Remove fd_install() from anon_inode_getfd() Avi Kivity
2008-02-27 19:41 ` Davide Libenzi
2008-02-27 19:41 ` Davide Libenzi
2008-02-27 20:14 ` Roland Dreier
2008-02-27 20:30 ` Davide Libenzi
2008-02-27 21:05 ` Roland Dreier
2008-02-27 21:05 ` Roland Dreier
2008-02-27 23:42 ` Roland Dreier
2008-02-27 23:42 ` Roland Dreier
2008-02-28 7:52 ` Avi Kivity
2008-02-28 20:04 ` Davide Libenzi
2008-02-28 20:24 ` Roland Dreier
2008-02-28 20:52 ` Davide Libenzi
2008-03-05 9:32 ` [kvm-devel] " Avi Kivity
2008-03-05 9:32 ` Avi Kivity
2008-03-06 15:14 ` Christoph Hellwig
2008-03-06 15:14 ` Christoph Hellwig
2008-03-09 2:45 ` Roland Dreier
2008-03-09 2:45 ` Roland Dreier
2008-03-17 10:40 ` Christoph Hellwig
2008-03-17 10:40 ` Christoph Hellwig
2008-03-17 10:48 ` Avi Kivity
2008-03-09 2:46 ` Roland Dreier
2008-03-09 2:46 ` Roland Dreier
2008-03-06 15:14 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080306151430.GD27894@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=avi@qumranet.com \
--cc=davidel@xmailserver.org \
--cc=hch@lst.de \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.