From: Roland Dreier <rdreier@cisco.com>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Christoph Hellwig <hch@lst.de>,
linux-fsdevel@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Avi Kivity <avi@qumranet.com>,
kvm-devel@lists.sourceforge.net,
Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@ftp.linux.org.uk>
Subject: Re: [PATCH/RFC 1/2] anon-inodes: Remove fd_install() from anon_inode_getfd()
Date: Wed, 27 Feb 2008 13:05:55 -0800 [thread overview]
Message-ID: <ada7igqyurw.fsf@cisco.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0802271218210.377@alien.or.mcafeemobile.com> (Davide Libenzi's message of "Wed, 27 Feb 2008 12:30:55 -0800 (PST)")
> http://git.kernel.org/?p=linux/kernel/git/viro/vfs-2.6.git;a=commit;h=49be4f8114e6ff0efdab10ebba2493fb67bc3034
>
> I'm fine with both approaches.
Both ways are OK with me too, although Al's change leaves the trap in
the anon_inode_getfd() in that all users have to keep in mind the race
against close() from another thread. Also Al's change moves all
documentation to __anon_inode_getfd() and leaves anon_inode_getfd()
undocumented, which is a little suboptimal.
With Al's change the 2/2 patch would have to change uverbs to use the
__anon_inode_getfd() variant and change the fd_install() in uverbs to
use fput(). If there is consensus that Al's patch will be merged for
2.6.26 I will write that patch and send it to Al to merge via his
tree, so that get_empty_filp() can be unexported.
- R.
WARNING: multiple messages have this Message-ID (diff)
From: Roland Dreier <rdreier@cisco.com>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: kvm-devel@lists.sourceforge.net,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Avi Kivity <avi@qumranet.com>, Al Viro <viro@ftp.linux.org.uk>,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH/RFC 1/2] anon-inodes: Remove fd_install() from anon_inode_getfd()
Date: Wed, 27 Feb 2008 13:05:55 -0800 [thread overview]
Message-ID: <ada7igqyurw.fsf@cisco.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0802271218210.377@alien.or.mcafeemobile.com> (Davide Libenzi's message of "Wed, 27 Feb 2008 12:30:55 -0800 (PST)")
> http://git.kernel.org/?p=linux/kernel/git/viro/vfs-2.6.git;a=commit;h=49be4f8114e6ff0efdab10ebba2493fb67bc3034
>
> I'm fine with both approaches.
Both ways are OK with me too, although Al's change leaves the trap in
the anon_inode_getfd() in that all users have to keep in mind the race
against close() from another thread. Also Al's change moves all
documentation to __anon_inode_getfd() and leaves anon_inode_getfd()
undocumented, which is a little suboptimal.
With Al's change the 2/2 patch would have to change uverbs to use the
__anon_inode_getfd() variant and change the fd_install() in uverbs to
use fput(). If there is consensus that Al's patch will be merged for
2.6.26 I will write that patch and send it to Al to merge via his
tree, so that get_empty_filp() can be unexported.
- R.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-02-27 21:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-25 19:10 [PATCH] uverbs: kill last remaining modular get_empty_filp user Christoph Hellwig
2008-02-27 19:01 ` Roland Dreier
2008-02-27 19:16 ` [PATCH/RFC 1/2] anon-inodes: Remove fd_install() from anon_inode_getfd() Roland Dreier
2008-02-27 19:16 ` Roland Dreier
2008-02-27 19:18 ` [PATCH 2/2] IB/uverbs: Use anonymous inodes instead of private filesystem Roland Dreier
2008-02-27 19:20 ` [PATCH/RFC 1/2] anon-inodes: Remove fd_install() from anon_inode_getfd() Avi Kivity
2008-02-27 19:41 ` Davide Libenzi
2008-02-27 19:41 ` Davide Libenzi
2008-02-27 20:14 ` Roland Dreier
2008-02-27 20:30 ` Davide Libenzi
2008-02-27 21:05 ` Roland Dreier [this message]
2008-02-27 21:05 ` Roland Dreier
2008-02-27 23:42 ` Roland Dreier
2008-02-27 23:42 ` Roland Dreier
2008-02-28 7:52 ` Avi Kivity
2008-02-28 20:04 ` Davide Libenzi
2008-02-28 20:24 ` Roland Dreier
2008-02-28 20:52 ` Davide Libenzi
2008-03-05 9:32 ` [kvm-devel] " Avi Kivity
2008-03-05 9:32 ` Avi Kivity
2008-03-06 15:14 ` Christoph Hellwig
2008-03-06 15:14 ` Christoph Hellwig
2008-03-09 2:45 ` Roland Dreier
2008-03-09 2:45 ` Roland Dreier
2008-03-17 10:40 ` Christoph Hellwig
2008-03-17 10:40 ` Christoph Hellwig
2008-03-17 10:48 ` Avi Kivity
2008-03-09 2:46 ` Roland Dreier
2008-03-09 2:46 ` Roland Dreier
2008-03-06 15:14 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada7igqyurw.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@linux-foundation.org \
--cc=avi@qumranet.com \
--cc=davidel@xmailserver.org \
--cc=hch@lst.de \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.