From: Ingo Molnar <mingo@elte.hu>
To: Pavel Machek <pavel@ucw.cz>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>,
Christoph Hellwig <hch@infradead.org>,
hpa@zytor.com, tglx@linutronix.de, andi@firstfloor.org,
linux-kernel@vger.kernel.org,
Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [patch 2/2] x86, fpu: lazy allocation of FPU area - v3
Date: Thu, 6 Mar 2008 16:51:41 +0100 [thread overview]
Message-ID: <20080306155141.GA23340@elte.hu> (raw)
In-Reply-To: <20080305194705.GA4386@ucw.cz>
* Pavel Machek <pavel@ucw.cz> wrote:
> > > kmem_cache_alloc() can fail (return NULL) and not handling it is a
> > > bug.
> >
> > oops. you are correct. Will send a sigsegv in the failure case then.
> > Thanks.
>
> You are introducing possibility of hard to debug error, where previous
> code just worked... Does not look like good idea to me.
hm, how does it differ from any other allocation failure? We could fail
to allocate a pagetable page. We could fail to allocate the task_struct
to begin with.
Ingo
next prev parent reply other threads:[~2008-03-06 15:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-03 23:02 [patch 1/2] x86, fpu: split FPU state from task struct - v3 Suresh Siddha
2008-03-03 23:02 ` [patch 2/2] x86, fpu: lazy allocation of FPU area " Suresh Siddha
2008-03-04 1:20 ` Christoph Hellwig
2008-03-04 1:43 ` Suresh Siddha
2008-03-04 10:32 ` Ingo Molnar
2008-03-04 17:55 ` Suresh Siddha
2008-03-05 19:47 ` Pavel Machek
2008-03-06 15:51 ` Ingo Molnar [this message]
2008-03-06 19:10 ` Suresh Siddha
2008-03-06 20:24 ` Pavel Machek
2008-03-06 20:52 ` Andi Kleen
2008-03-07 12:29 ` H. Peter Anvin
2008-03-07 13:06 ` Arjan van de Ven
2008-03-07 13:18 ` Andi Kleen
2008-03-07 13:20 ` Arjan van de Ven
2008-03-07 13:27 ` Andi Kleen
2008-03-05 19:48 ` Pavel Machek
2008-03-06 19:26 ` Suresh Siddha
2008-03-06 21:21 ` Pavel Machek
2008-03-04 1:18 ` [patch 1/2] x86, fpu: split FPU state from task struct " Christoph Hellwig
2008-03-04 1:36 ` Suresh Siddha
2008-03-04 8:20 ` Ingo Molnar
2008-03-06 12:39 ` Christoph Hellwig
2008-03-04 10:28 ` Ingo Molnar
2008-03-04 17:59 ` Suresh Siddha
2008-03-04 20:53 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080306155141.GA23340@elte.hu \
--to=mingo@elte.hu \
--cc=andi@firstfloor.org \
--cc=arjan@linux.intel.com \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.