From: Greg KH <greg@kroah.com>
To: Adrian McMenamin <adrian@newgolddream.dyndns.info>
Cc: Adrian McMenamin <lkmladrian@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-sh <linux-sh@vger.kernel.org>
Subject: Re: Behaviour of device_register
Date: Thu, 06 Mar 2008 16:30:32 +0000 [thread overview]
Message-ID: <20080306163032.GA12982@kroah.com> (raw)
In-Reply-To: <8031.85.118.17.158.1204806681.squirrel@newgolddream.dyndns.info>
On Thu, Mar 06, 2008 at 12:31:21PM -0000, Adrian McMenamin wrote:
> On Wed, March 5, 2008 11:46 pm, Greg KH wrote:
> > On Wed, Mar 05, 2008 at 11:25:48PM +0000, Adrian McMenamin wrote:
> >> The observed behaviour for me is that it appears to be blocking the
> >> vblank interrupt on my box (or more accurately stopping the workqueue
> >> that the interrupt handler calls from running). And without the vblank
> >> my bus won't process dma and so therefore the attempt to register the
> >> device in question fails.
> >>
> >> But I can see no reason from a glance over the code why that (vblanks
> >> being blocked) would be the case - have I missed something and the
> >> vblanks will be blocked, or should I be looking elsewhere for the root
> >> cause of this problem?
> >
> > device_register(), on it's own, does not touch any hardware, nor prevent
> > anything else in the kernel from happening.
> >
> > So I think you need to look elsewhere, like into the bus that is doing
> > the device_register() call :)
> >
>
>
> It turns out this is a lock contention issue.
>
> The code blocks waiting for a lock that will never be freed.
The device_register() code blocks? Or something else?
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Adrian McMenamin <adrian@newgolddream.dyndns.info>
Cc: Adrian McMenamin <lkmladrian@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-sh <linux-sh@vger.kernel.org>
Subject: Re: Behaviour of device_register
Date: Thu, 6 Mar 2008 08:30:32 -0800 [thread overview]
Message-ID: <20080306163032.GA12982@kroah.com> (raw)
In-Reply-To: <8031.85.118.17.158.1204806681.squirrel@newgolddream.dyndns.info>
On Thu, Mar 06, 2008 at 12:31:21PM -0000, Adrian McMenamin wrote:
> On Wed, March 5, 2008 11:46 pm, Greg KH wrote:
> > On Wed, Mar 05, 2008 at 11:25:48PM +0000, Adrian McMenamin wrote:
> >> The observed behaviour for me is that it appears to be blocking the
> >> vblank interrupt on my box (or more accurately stopping the workqueue
> >> that the interrupt handler calls from running). And without the vblank
> >> my bus won't process dma and so therefore the attempt to register the
> >> device in question fails.
> >>
> >> But I can see no reason from a glance over the code why that (vblanks
> >> being blocked) would be the case - have I missed something and the
> >> vblanks will be blocked, or should I be looking elsewhere for the root
> >> cause of this problem?
> >
> > device_register(), on it's own, does not touch any hardware, nor prevent
> > anything else in the kernel from happening.
> >
> > So I think you need to look elsewhere, like into the bus that is doing
> > the device_register() call :)
> >
>
>
> It turns out this is a lock contention issue.
>
> The code blocks waiting for a lock that will never be freed.
The device_register() code blocks? Or something else?
next prev parent reply other threads:[~2008-03-06 16:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-05 23:25 Behaviour of device_register Adrian McMenamin
2008-03-05 23:25 ` Adrian McMenamin
2008-03-05 23:46 ` Greg KH
2008-03-05 23:46 ` Greg KH
2008-03-06 12:31 ` Adrian McMenamin
2008-03-06 12:31 ` Adrian McMenamin
2008-03-06 16:30 ` Greg KH [this message]
2008-03-06 16:30 ` Greg KH
2008-03-06 17:51 ` Adrian McMenamin
2008-03-06 17:51 ` Adrian McMenamin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080306163032.GA12982@kroah.com \
--to=greg@kroah.com \
--cc=adrian@newgolddream.dyndns.info \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=lkmladrian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.