Re: [PATCH] kvm: provide kvm.h for all architecture: fixes headers_install

[Andrew Morton <akpm@linux-foundation.org>]

On Mon, 10 Mar 2008 14:11:04 +0100 Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> [PATCH v2] kvm: provide kvm.h for all architecture: fixes headers_install
> 
> Currently include/linux/kvm.h is not considered by make headers_install, 
> because Kbuild cannot handle " unifdef-$(CONFIG_FOO) += foo.h. 
> This problem was introduced by 040922c04cf2c8ac70be2e88a8a9614ecdb41d2e, 
> which makes this an 2.6.25 regression.
> 
> One way of solving the issue is to enhance Kbuild, but Avi Kivity and David
> Woodhouse conviced me, that changing headers_install is not the way to go. 
> This patch changes the definition for linux/kvm.h to unifdef-y.
> 
> If  unifdef-y is used for linux/kvm.h "make headers_check" will fail on all
> architectures without asm/kvm.h. Therefore, this patch also provides 
> asm/kvm.h on all architectures.
> 
> Changes since v1:
> o use asm-generic/Kbuild.asm (Arnd Bergmann)
> o fix comment in asm-frv (David Howells)

err, this doesn't work.

alpha and m68k (at least) fail make headers_check

/usr/src/devel/usr/include/linux/kvm.h requires asm/kvm.h, which does not exist in exported headers

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/