All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matteo Croce <technoboy85@gmail.com>
To: linux-mips@linux-mips.org, linux-net@vger.kernel.org
Cc: Eugene Konev <ejka@imfi.kspu.ru>,
	netdev@vger.kernel.org, davem@davemloft.net,
	kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org,
	yoshfuji@linux-ipv6.org, kaber@coreworks.de,
	Andrew Morton <akpm@linux-foundation.org>,
	Jeff Garzik <jgarzik@pobox.com>,
	Anton Vorontsov <avorontsov@ru.mvista.com>
Subject: [PATCH][MIPS][6/6]: AR7 leds
Date: Wed, 12 Mar 2008 02:34:39 +0100	[thread overview]
Message-ID: <200803120234.40306.technoboy85@gmail.com> (raw)
In-Reply-To: <200803120221.25044.technoboy85@gmail.com>

Signed-off-by: Matteo Croce <technoboy85@gmail.com>
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>

diff --git a/drivers/net/cpmac.c b/drivers/net/cpmac.c
index c85194f..05191b6 100644
--- a/drivers/net/cpmac.c
+++ b/drivers/net/cpmac.c
@@ -1006,23 +1006,10 @@ static int __devinit cpmac_probe(struct platform_device *pdev)
 
 	if (phy_id == PHY_MAX_ADDR) {
 		if (external_switch || dumb_switch) {
-			struct fixed_phy_status status = {};
-
-			mdio_bus_id = 0;
-
-			/*
-			 * FIXME: this should be in the platform code!
-			 * Since there is not platform code at all (that is,
-			 * no mainline users of that driver), place it here
-			 * for now.
-			 */
-			phy_id = 0;
-			status.link = 1;
-			status.duplex = 1;
-			status.speed = 100;
-			fixed_phy_add(PHY_POLL, phy_id, &status);
+			mdio_bus_id = 0; /* fixed phys bus */
+			phy_id = pdev->id;
 		} else {
-			printk(KERN_ERR "cpmac: no PHY present\n");
+			dev_err(&pdev->dev, "no PHY present\n");
 			return -ENODEV;
 		}
 	}

  parent reply	other threads:[~2008-03-12  1:34 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-12  1:21 [PATCH][MIPS][0/6]: AR7 final Matteo Croce
2008-03-12  1:25 ` [PATCH][MIPS][2/6]: AR7 mtd partition map Matteo Croce
2008-03-12  1:25   ` Matteo Croce
2008-03-12  1:26 ` [PATCH][MIPS][3/6]: AR7: VLYNQ bus Matteo Croce
2008-03-29  9:59   ` Florian Lohoff
2008-04-02 12:56     ` Matteo Croce
2008-04-02 18:31       ` Florian Lohoff
2008-04-03  0:19         ` Matteo Croce
2008-04-03  6:08           ` Florian Lohoff
2008-04-02 13:57     ` Matteo Croce
2008-04-02 14:58     ` Matteo Croce
2008-03-12  1:28 ` [PATCH][MIPS][4/6]: AR7 gpio Matteo Croce
2008-03-12  1:30 ` [PATCH][MIPS][5/6]: AR7: serial hack Matteo Croce
2008-03-12  9:31   ` Thomas Bogendoerfer
2008-03-13  0:38     ` Matteo Croce
2008-03-13  8:45       ` Thomas Bogendoerfer
2008-03-14 15:46         ` Matteo Croce
2008-03-15 10:40           ` Thomas Bogendoerfer
2008-03-16 15:45             ` Matteo Croce
2008-03-18 13:30               ` Thomas Bogendoerfer
2008-03-18 13:43                 ` Sergei Shtylyov
2008-03-18 13:49                   ` Sergei Shtylyov
2008-03-18 14:01                 ` Alan Cox
2008-03-18 14:01                   ` Alan Cox
2008-03-18 15:28                   ` Thomas Bogendoerfer
2008-03-21  1:55               ` Thomas Bogendoerfer
2008-03-27 21:14                 ` Matteo Croce
2008-03-27 21:17                 ` Matteo Croce
2008-03-15 11:38           ` Alan Cox
2008-03-12 11:16   ` Alan Cox
2008-03-13  0:31     ` Matteo Croce
2008-03-13  9:01       ` Thomas Bogendoerfer
2008-03-16 15:27         ` Matteo Croce
2008-03-16 15:49         ` Matteo Croce
2008-03-12  1:34 ` Matteo Croce [this message]
2008-03-13  0:34   ` [PATCH][MIPS][6/6]: AR7 leds Matteo Croce
2008-03-12 18:06 ` [PATCH][MIPS][1/6]: AR7: core Matteo Croce
2008-03-12 19:33   ` Ralf Baechle
2008-03-29 10:34   ` Florian Lohoff
  -- strict thread matches above, loose matches on Subject: below --
2007-12-27 18:19 [PATCH][MIPS][0/6]: AR7 refresh Matteo Croce
2007-12-27 18:32 ` [PATCH][MIPS][6/6]: AR7 leds Matteo Croce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803120234.40306.technoboy85@gmail.com \
    --to=technoboy85@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=avorontsov@ru.mvista.com \
    --cc=davem@davemloft.net \
    --cc=ejka@imfi.kspu.ru \
    --cc=jgarzik@pobox.com \
    --cc=jmorris@namei.org \
    --cc=kaber@coreworks.de \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-net@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pekkas@netcore.fi \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.