* [PATCH] x86: parocessor.h - use PAGE_SIZE instead of numeric constant
@ 2008-03-12 20:14 Cyrill Gorcunov
2008-03-12 21:10 ` H. Peter Anvin
0 siblings, 1 reply; 3+ messages in thread
From: Cyrill Gorcunov @ 2008-03-12 20:14 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Thomas Gleixner, H. Peter Anvin, LKML
This patch replaces numeric constant with an appropriate macro
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
Index: linux-2.6.git/include/asm-x86/processor.h
===================================================================
--- linux-2.6.git.orig/include/asm-x86/processor.h 2008-02-20 19:14:57.000000000 +0300
+++ linux-2.6.git/include/asm-x86/processor.h 2008-03-12 23:10:02.000000000 +0300
@@ -786,7 +786,7 @@ extern unsigned long thread_saved_pc(str
/*
* User space process size. 47bits minus one guard page.
*/
-#define TASK_SIZE64 (0x800000000000UL - 4096)
+#define TASK_SIZE64 (0x800000000000UL - PAGE_SIZE)
/* This decides where the kernel will search for a free chunk of vm
* space during mmap's.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: parocessor.h - use PAGE_SIZE instead of numeric constant
2008-03-12 20:14 [PATCH] x86: parocessor.h - use PAGE_SIZE instead of numeric constant Cyrill Gorcunov
@ 2008-03-12 21:10 ` H. Peter Anvin
2008-03-12 21:21 ` Cyrill Gorcunov
0 siblings, 1 reply; 3+ messages in thread
From: H. Peter Anvin @ 2008-03-12 21:10 UTC (permalink / raw)
To: Cyrill Gorcunov; +Cc: Ingo Molnar, Thomas Gleixner, LKML
Cyrill Gorcunov wrote:
> This patch replaces numeric constant with an appropriate macro
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
>
> ---
>
> Index: linux-2.6.git/include/asm-x86/processor.h
> ===================================================================
> --- linux-2.6.git.orig/include/asm-x86/processor.h 2008-02-20 19:14:57.000000000 +0300
> +++ linux-2.6.git/include/asm-x86/processor.h 2008-03-12 23:10:02.000000000 +0300
> @@ -786,7 +786,7 @@ extern unsigned long thread_saved_pc(str
> /*
> * User space process size. 47bits minus one guard page.
> */
> -#define TASK_SIZE64 (0x800000000000UL - 4096)
> +#define TASK_SIZE64 (0x800000000000UL - PAGE_SIZE)
>
> /* This decides where the kernel will search for a free chunk of vm
> * space during mmap's.
Although I'd personally prefer ((1UL << 47) - PAGE_SIZE)
-hpa
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: parocessor.h - use PAGE_SIZE instead of numeric constant
2008-03-12 21:10 ` H. Peter Anvin
@ 2008-03-12 21:21 ` Cyrill Gorcunov
0 siblings, 0 replies; 3+ messages in thread
From: Cyrill Gorcunov @ 2008-03-12 21:21 UTC (permalink / raw)
To: H. Peter Anvin; +Cc: Ingo Molnar, Thomas Gleixner, LKML
Yep, it wold be more elegant, i'll fix it tomorrow. (sorry for
top-posting, i'm not on my local laptop now)
On 3/13/08, H. Peter Anvin <hpa@zytor.com> wrote:
> Cyrill Gorcunov wrote:
> > This patch replaces numeric constant with an appropriate macro
> >
> > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> >
> > ---
> >
> > Index: linux-2.6.git/include/asm-x86/processor.h
> > ===================================================================
> > --- linux-2.6.git.orig/include/asm-x86/processor.h 2008-02-20
> 19:14:57.000000000 +0300
> > +++ linux-2.6.git/include/asm-x86/processor.h 2008-03-12
> 23:10:02.000000000 +0300
> > @@ -786,7 +786,7 @@ extern unsigned long thread_saved_pc(str
> > /*
> > * User space process size. 47bits minus one guard page.
> > */
> > -#define TASK_SIZE64 (0x800000000000UL - 4096)
> > +#define TASK_SIZE64 (0x800000000000UL - PAGE_SIZE)
> >
> > /* This decides where the kernel will search for a free chunk of vm
> > * space during mmap's.
>
> Although I'd personally prefer ((1UL << 47) - PAGE_SIZE)
>
> -hpa
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-03-12 21:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-12 20:14 [PATCH] x86: parocessor.h - use PAGE_SIZE instead of numeric constant Cyrill Gorcunov
2008-03-12 21:10 ` H. Peter Anvin
2008-03-12 21:21 ` Cyrill Gorcunov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.