* [PATCH] x86_64: free_bootmem should take phy
@ 2008-03-13 19:13 Yinghai Lu
2008-03-13 22:04 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Yinghai Lu @ 2008-03-13 19:13 UTC (permalink / raw)
To: Ingo Molnar, Andrew Morton
Cc: clameter, linux-kernel, ak, y-goto, kamezawa.hiroyu
[-- Attachment #1: Type: text/plain, Size: 1 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: x86_numa_64_free_use_phys.patch --]
[-- Type: text/x-patch; name=x86_numa_64_free_use_phys.patch, Size: 647 bytes --]
[PATCH] x86_64: free_bootmem should take phys
so use nodedata_phys directly.
Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
diff --git a/arch/x86/mm/numa_64.c b/arch/x86/mm/numa_64.c
index 0c9b2bd..18267a0 100644
--- a/arch/x86/mm/numa_64.c
+++ b/arch/x86/mm/numa_64.c
@@ -221,8 +221,7 @@ void __init setup_node_bootmem(int nodeid, unsigned long start,
bootmap_pages<<PAGE_SHIFT, PAGE_SIZE);
if (bootmap == NULL) {
if (nodedata_phys < start || nodedata_phys >= end)
- free_bootmem((unsigned long)node_data[nodeid],
- pgdat_size);
+ free_bootmem(nodedata_phys, pgdat_size);
node_data[nodeid] = NULL;
return;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86_64: free_bootmem should take phy
2008-03-13 19:13 [PATCH] x86_64: free_bootmem should take phy Yinghai Lu
@ 2008-03-13 22:04 ` Andrew Morton
2008-03-13 22:10 ` Yinghai Lu
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2008-03-13 22:04 UTC (permalink / raw)
To: Yinghai Lu; +Cc: mingo, clameter, linux-kernel, ak, y-goto, kamezawa.hiroyu
On Thu, 13 Mar 2008 12:13:23 -0700
"Yinghai Lu" <yhlu.kernel@gmail.com> wrote:
> [PATCH] x86_64: free_bootmem should take phys
>
> so use nodedata_phys directly.
>
> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
>
> diff --git a/arch/x86/mm/numa_64.c b/arch/x86/mm/numa_64.c
> index 0c9b2bd..18267a0 100644
> --- a/arch/x86/mm/numa_64.c
> +++ b/arch/x86/mm/numa_64.c
> @@ -221,8 +221,7 @@ void __init setup_node_bootmem(int nodeid, unsigned long start,
> bootmap_pages<<PAGE_SHIFT, PAGE_SIZE);
> if (bootmap == NULL) {
> if (nodedata_phys < start || nodedata_phys >= end)
> - free_bootmem((unsigned long)node_data[nodeid],
> - pgdat_size);
> + free_bootmem(nodedata_phys, pgdat_size);
> node_data[nodeid] = NULL;
> return;
> }
>
Can you please confirm that this change has no dependency upon your other
recent changes?
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86_64: free_bootmem should take phy
2008-03-13 22:04 ` Andrew Morton
@ 2008-03-13 22:10 ` Yinghai Lu
0 siblings, 0 replies; 3+ messages in thread
From: Yinghai Lu @ 2008-03-13 22:10 UTC (permalink / raw)
To: Andrew Morton; +Cc: mingo, clameter, linux-kernel, ak, y-goto, kamezawa.hiroyu
On Thu, Mar 13, 2008 at 3:04 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Thu, 13 Mar 2008 12:13:23 -0700
> "Yinghai Lu" <yhlu.kernel@gmail.com> wrote:
>
> > [PATCH] x86_64: free_bootmem should take phys
> >
> > so use nodedata_phys directly.
> >
> > Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
> >
> > diff --git a/arch/x86/mm/numa_64.c b/arch/x86/mm/numa_64.c
> > index 0c9b2bd..18267a0 100644
> > --- a/arch/x86/mm/numa_64.c
> > +++ b/arch/x86/mm/numa_64.c
> > @@ -221,8 +221,7 @@ void __init setup_node_bootmem(int nodeid, unsigned long start,
> > bootmap_pages<<PAGE_SHIFT, PAGE_SIZE);
> > if (bootmap == NULL) {
> > if (nodedata_phys < start || nodedata_phys >= end)
> > - free_bootmem((unsigned long)node_data[nodeid],
> > - pgdat_size);
> > + free_bootmem(nodedata_phys, pgdat_size);
> > node_data[nodeid] = NULL;
> > return;
> > }
> >
>
> Can you please confirm that this change has no dependency upon your other
> recent changes?
it has not dependency upon to other recent changes.
YH
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-03-13 22:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-13 19:13 [PATCH] x86_64: free_bootmem should take phy Yinghai Lu
2008-03-13 22:04 ` Andrew Morton
2008-03-13 22:10 ` Yinghai Lu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.