All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Christoph Lameter <clameter@sgi.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [2/2] vmallocinfo: Add caller information
Date: Wed, 19 Mar 2008 22:42:27 +0100	[thread overview]
Message-ID: <20080319214227.GA4454@elte.hu> (raw)
In-Reply-To: <20080318222827.519656153@sgi.com>


* Christoph Lameter <clameter@sgi.com> wrote:

> Add caller information so that /proc/vmallocinfo shows where the 
> allocation request for a slice of vmalloc memory originated.

please use one simple save_stack_trace() instead of polluting a dozen 
architectures with:

> -	return __ioremap(phys_addr, size, IOR_MODE_UNCACHED);
> +	return __ioremap_caller(phys_addr, size, IOR_MODE_UNCACHED,
> +						__builtin_return_address(0));

	Ingo

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Christoph Lameter <clameter@sgi.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [2/2] vmallocinfo: Add caller information
Date: Wed, 19 Mar 2008 22:42:27 +0100	[thread overview]
Message-ID: <20080319214227.GA4454@elte.hu> (raw)
In-Reply-To: <20080318222827.519656153@sgi.com>

* Christoph Lameter <clameter@sgi.com> wrote:

> Add caller information so that /proc/vmallocinfo shows where the 
> allocation request for a slice of vmalloc memory originated.

please use one simple save_stack_trace() instead of polluting a dozen 
architectures with:

> -	return __ioremap(phys_addr, size, IOR_MODE_UNCACHED);
> +	return __ioremap_caller(phys_addr, size, IOR_MODE_UNCACHED,
> +						__builtin_return_address(0));

	Ingo

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-03-19 23:16 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-18 22:27 [0/2] vmalloc: Add /proc/vmallocinfo to display mappings Christoph Lameter
2008-03-18 22:27 ` Christoph Lameter
2008-03-18 22:27 ` [1/2] vmalloc: Show vmalloced areas via /proc/vmallocinfo Christoph Lameter
2008-03-18 22:27   ` Christoph Lameter
2008-03-20  4:04   ` Arjan van de Ven
2008-03-20  4:04     ` Arjan van de Ven
2008-03-20 19:22     ` Christoph Lameter
2008-03-20 19:22       ` Christoph Lameter
2008-03-21 22:19       ` Andrew Morton
2008-03-21 22:19         ` Andrew Morton
2008-03-21 22:09         ` Alan Cox
2008-03-21 22:09           ` Alan Cox
2008-03-18 22:27 ` [2/2] vmallocinfo: Add caller information Christoph Lameter
2008-03-18 22:27   ` Christoph Lameter
2008-03-19 21:42   ` Ingo Molnar [this message]
2008-03-19 21:42     ` Ingo Molnar
2008-03-20  0:03     ` Christoph Lameter
2008-03-20  0:03       ` Christoph Lameter
2008-03-21 11:00       ` Ingo Molnar
2008-03-21 11:00         ` Ingo Molnar
2008-03-21 17:35         ` Christoph Lameter
2008-03-21 17:35           ` Christoph Lameter
2008-03-21 18:45           ` Ingo Molnar
2008-03-21 18:45             ` Ingo Molnar
2008-03-21 19:16             ` Christoph Lameter
2008-03-21 19:16               ` Christoph Lameter
2008-03-21 20:55               ` Ingo Molnar
2008-03-21 20:55                 ` Ingo Molnar
2008-03-22  2:40                 ` Mike Frysinger
2008-03-22  2:40                   ` Mike Frysinger
2008-04-29  8:48   ` Ingo Molnar
2008-04-29  8:48     ` Ingo Molnar
2008-04-29 17:08     ` Christoph Lameter
2008-04-29 17:08       ` Christoph Lameter
2008-04-28 19:48       ` Arjan van de Ven
2008-04-28 19:48         ` Arjan van de Ven
2008-04-29 18:49         ` Christoph Lameter
2008-04-29 18:49           ` Christoph Lameter
2008-04-28 21:00           ` Arjan van de Ven
2008-04-28 21:00             ` Arjan van de Ven
2008-04-29 19:09             ` Christoph Lameter
2008-04-29 19:09               ` Christoph Lameter
2008-04-29 19:23               ` Pekka Enberg
2008-04-29 19:23                 ` Pekka Enberg
2008-04-29 19:29                 ` Pekka Enberg
2008-04-29 19:29                   ` Pekka Enberg
2008-04-29 19:29               ` Ingo Molnar
2008-04-29 19:29                 ` Ingo Molnar
2008-03-19  2:23 ` [0/2] vmalloc: Add /proc/vmallocinfo to display mappings KOSAKI Motohiro
2008-03-19  2:23   ` KOSAKI Motohiro
2008-03-19 22:07   ` Andrew Morton
2008-03-19 22:07     ` Andrew Morton
2008-03-19 23:33     ` Christoph Lameter
2008-03-19 23:33       ` Christoph Lameter
2008-03-20  7:43     ` KOSAKI Motohiro
2008-03-20  7:43       ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080319214227.GA4454@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.