From: Andi Kleen <andi@firstfloor.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andi Kleen <andi@firstfloor.org>,
andreas.herrmann3@amd.com, mingo@elte.hu,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [5/7] Readd rdmsrl_safe
Date: Fri, 21 Mar 2008 18:16:36 +0100 [thread overview]
Message-ID: <20080321171636.GE2346@one.firstfloor.org> (raw)
In-Reply-To: <alpine.LFD.1.00.0803211756000.3781@apollo.tec.linutronix.de>
On Fri, Mar 21, 2008 at 06:06:13PM +0100, Thomas Gleixner wrote:
> On Wed, 12 Mar 2008, Andi Kleen wrote:
> > RDMSR for 64bit values with exception handling.
> >
> > Makes it easier to deal with 64bit valued MSRs. The old 64bit code
> > base had that too as checking_rdmsrl(), but it got dropped somehow.
>
> Yup, no users.
>
> > +#define rdmsrl_safe(msr,p) \
> > + ({ int __err; *(p) = native_read_msr_safe(msr, &__err); __err; })
> > +
>
> static inline please
Well all of paravirt.h uses macros. I did the same for consistency. If you want
inlines it would be better to just convert it all in one go (but please only
after this patch was applied)
-Andi
next prev parent reply other threads:[~2008-03-21 17:14 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 2:53 [PATCH] [1/7] Implement true end_pfn_mapped for 32bit Andi Kleen
2008-03-12 2:53 ` [PATCH] [2/7] Account overlapped mappings in end_pfn_map Andi Kleen
2008-03-12 2:53 ` [PATCH] [3/7] Add set_memory_4k to pageattr.c Andi Kleen
2008-03-12 2:53 ` [PATCH] [4/7] Don't use large pages to map the first 2/4MB of memory Andi Kleen
2008-03-12 5:38 ` Eric Dumazet
2008-03-12 9:19 ` Andi Kleen
2008-03-21 17:45 ` Thomas Gleixner
2008-03-21 17:59 ` Andi Kleen
2008-03-21 18:03 ` Thomas Gleixner
2008-03-21 18:44 ` Andi Kleen
2008-03-25 11:31 ` Joerg Roedel
2008-03-25 11:39 ` Andi Kleen
2008-03-12 2:53 ` [PATCH] [5/7] Readd rdmsrl_safe Andi Kleen
2008-03-21 17:06 ` Thomas Gleixner
2008-03-21 17:16 ` Andi Kleen [this message]
2008-03-21 17:58 ` Thomas Gleixner
2008-03-21 18:06 ` Andi Kleen
2008-03-21 18:14 ` Thomas Gleixner
2008-03-21 18:46 ` Andi Kleen
2008-03-21 18:48 ` [PATCH] [5/7] Readd rdmsrl_safe II Andi Kleen
2008-03-22 9:59 ` [PATCH] Readd rdmsrl_safe v2 Andi Kleen
2008-03-12 2:53 ` [PATCH] [6/7] Split large page mapping for AMD TSEG Andi Kleen
2008-03-21 17:55 ` Thomas Gleixner
2008-03-25 11:56 ` Joerg Roedel
2008-03-25 16:44 ` Thomas Gleixner
2008-03-25 16:54 ` Andi Kleen
2008-03-12 2:53 ` [PATCH] [7/7] CPA: Add statistics about state of direct mapping v2 Andi Kleen
2008-03-21 17:41 ` Thomas Gleixner
2008-03-21 17:55 ` Andi Kleen
2008-03-22 9:50 ` [PATCH] CPA: Add statistics about state of direct mapping v3 Andi Kleen
2008-03-25 15:40 ` Thomas Gleixner
2008-03-25 16:14 ` Andi Kleen
2008-03-25 16:16 ` Thomas Gleixner
2008-03-25 17:01 ` [PATCH] CPA: Add statistics about state of direct mapping v4 Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080321171636.GE2346@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=andreas.herrmann3@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.