From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>,
jb.faq@gmx.de,
IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH #upstream-fixes] libata: assume no device is attached if both IDENTIFYs are aborted
Date: Sun, 23 Mar 2008 12:46:09 +0000 [thread overview]
Message-ID: <20080323124609.6e3b04cc@core> (raw)
In-Reply-To: <47E5F5D5.6050203@gmail.com>
On Sun, 23 Mar 2008 15:16:53 +0900
Tejun Heo <htejun@gmail.com> wrote:
> This is to fix bugzilla #10254. QSI cdrom attached to pata_sis as
> secondary master appears as phantom device for the slave.
> Interestingly, instead of not setting DRQ after IDENTIFY which
> triggers NODEV_HINT, it aborts both IDENTIFY and IDENTIFY PACKET which
> makes EH retry.
>
> Modify EH such that it assumes no device is attached if both flavors
> of IDENTIFY are aborted by the device. There really isn't much point
> in retrying when the device actively aborts the commands.
>
> While at it, convert NODEV detection message to ata_dev_printk() to
> help debugging obscure detection problems.
>
> This problem was reported by Jan Bücken.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Jan Bücken <jb.faq@gmx.de>
> ---
> Alan, does this look okay?
Acked-by: Alan Cox <alan@redhat.com>
next prev parent reply other threads:[~2008-03-23 13:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-23 6:16 [PATCH #upstream-fixes] libata: assume no device is attached if both IDENTIFYs are aborted Tejun Heo
2008-03-23 12:46 ` Alan Cox [this message]
2008-03-25 2:26 ` Jeff Garzik
2008-03-26 14:05 ` Mark Lord
2008-03-26 14:43 ` Tejun Heo
2008-03-26 14:48 ` Mark Lord
2008-03-26 15:44 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080323124609.6e3b04cc@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=jb.faq@gmx.de \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.