Re: [PATCH #upstream-fixes] libata: assume no device is attached if both IDENTIFYs are aborted

[Jeff Garzik <jeff@garzik.org>]

Tejun Heo wrote:
> This is to fix bugzilla #10254.  QSI cdrom attached to pata_sis as
> secondary master appears as phantom device for the slave.
> Interestingly, instead of not setting DRQ after IDENTIFY which
> triggers NODEV_HINT, it aborts both IDENTIFY and IDENTIFY PACKET which
> makes EH retry.
> 
> Modify EH such that it assumes no device is attached if both flavors
> of IDENTIFY are aborted by the device.  There really isn't much point
> in retrying when the device actively aborts the commands.
> 
> While at it, convert NODEV detection message to ata_dev_printk() to
> help debugging obscure detection problems.
> 
> This problem was reported by Jan Bücken.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Jan Bücken <jb.faq@gmx.de>
> ---
> Alan, does this look okay?
> 
> Thanks.
> 
>  drivers/ata/libata-core.c |   38 ++++++++++++++++++++++++--------------
>  1 file changed, 24 insertions(+), 14 deletions(-)

applied