From: Jack Steiner <steiner@sgi.com>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: mingo@elte.hu, tglx@linutronix.de, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 1/8] x86_64: Change GET_APIC_ID() from an inline function to an out-of-line function
Date: Mon, 24 Mar 2008 20:37:59 -0500 [thread overview]
Message-ID: <20080325013759.GA16549@sgi.com> (raw)
In-Reply-To: <86802c440803241534p5c28193brf769280fe05d286d@mail.gmail.com>
> > Index: linux/include/asm-x86/apicdef.h
> > ===================================================================
> > --- linux.orig/include/asm-x86/apicdef.h 2008-03-18 14:54:19.000000000 -0500
> > +++ linux/include/asm-x86/apicdef.h 2008-03-21 09:07:23.000000000 -0500
> > @@ -14,7 +14,6 @@
> >
> > #ifdef CONFIG_X86_64
> > # define APIC_ID_MASK (0xFFu<<24)
> > -# define GET_APIC_ID(x) (((x)>>24)&0xFFu)
> > # define SET_APIC_ID(x) (((x)<<24))
> > #endif
>
> it this patch after smpboot.c integration?
>
> that patchsets have GET_APIC_ID in mach_apicdef.h instead of apicdef.h
>
Sorry - I meant to add to the patches that they are based on linux-2.6.25-rc5-mm1.
Was the change to smpboot.c made in -rc6??
--- jack
WARNING: multiple messages have this Message-ID (diff)
From: Jack Steiner <steiner@sgi.com>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: mingo@elte.hu, tglx@linutronix.de, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 1/8] x86_64: Change GET_APIC_ID() from an inline function to an out-of-line function
Date: Mon, 24 Mar 2008 20:37:59 -0500 [thread overview]
Message-ID: <20080325013759.GA16549@sgi.com> (raw)
In-Reply-To: <86802c440803241534p5c28193brf769280fe05d286d@mail.gmail.com>
> > Index: linux/include/asm-x86/apicdef.h
> > ===================================================================
> > --- linux.orig/include/asm-x86/apicdef.h 2008-03-18 14:54:19.000000000 -0500
> > +++ linux/include/asm-x86/apicdef.h 2008-03-21 09:07:23.000000000 -0500
> > @@ -14,7 +14,6 @@
> >
> > #ifdef CONFIG_X86_64
> > # define APIC_ID_MASK (0xFFu<<24)
> > -# define GET_APIC_ID(x) (((x)>>24)&0xFFu)
> > # define SET_APIC_ID(x) (((x)<<24))
> > #endif
>
> it this patch after smpboot.c integration?
>
> that patchsets have GET_APIC_ID in mach_apicdef.h instead of apicdef.h
>
Sorry - I meant to add to the patches that they are based on linux-2.6.25-rc5-mm1.
Was the change to smpboot.c made in -rc6??
--- jack
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-03-25 1:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-24 18:21 [RFC 1/8] x86_64: Change GET_APIC_ID() from an inline function to an out-of-line function Jack Steiner
2008-03-24 18:21 ` Jack Steiner
2008-03-24 22:34 ` Yinghai Lu
2008-03-24 22:34 ` Yinghai Lu
2008-03-25 1:37 ` Jack Steiner [this message]
2008-03-25 1:37 ` Jack Steiner
2008-03-25 2:18 ` Yinghai Lu
2008-03-25 2:18 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080325013759.GA16549@sgi.com \
--to=steiner@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.