From: Oliver Neukum <oliver@neukum.org>
To: linux-pm@lists.linux-foundation.org
Cc: Johannes Berg <johannes@sipsolutions.net>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Alexey Starikovskiy <astarikovskiy@suse.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [linux-pm] [RFC][PATCH] PM: Introduce new top level suspend and hibernation callbacks (rev. 2)
Date: Tue, 25 Mar 2008 10:49:24 +0100 [thread overview]
Message-ID: <200803251049.27696.oliver@neukum.org> (raw)
In-Reply-To: <1206058863.16475.165.camel@johannes.berg>
Am Freitag, 21. März 2008 01:21:03 schrieb Johannes Berg:
> > + * All of the above callbacks, except for @complete(), return error codes.
> > + * However, the error codes returned by the resume operations, @resume(),
> > + * @thaw(), and @restore(), are only printed in the system logs, since the PM
> > + * core cannot do anything else about them.
>
> Why bother and not just make them return void, the error printing can
> most likely be done much much better in the callback since that possibly
> has information on why it failed.
A device that cannot wake up is unusable. Shouldn't the pm core disconnect()
such a device?
Regards
Oliver
next prev parent reply other threads:[~2008-03-25 9:49 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-21 0:01 [RFC][PATCH] PM: Introduce new top level suspend and hibernation callbacks (rev. 2) Rafael J. Wysocki
2008-03-21 0:01 ` Rafael J. Wysocki
2008-03-21 0:21 ` [linux-pm] " Johannes Berg
2008-03-21 0:26 ` Rafael J. Wysocki
2008-03-21 0:26 ` Rafael J. Wysocki
2008-03-25 9:49 ` Oliver Neukum [this message]
2008-03-25 13:06 ` Rafael J. Wysocki
2008-03-25 13:06 ` [linux-pm] " Rafael J. Wysocki
2008-03-25 13:15 ` Oliver Neukum
2008-03-25 13:15 ` Oliver Neukum
2008-03-25 14:19 ` Alan Stern
2008-03-25 14:19 ` [linux-pm] " Alan Stern
2008-03-25 14:19 ` Alan Stern
2008-03-25 14:24 ` Oliver Neukum
2008-03-25 14:24 ` Oliver Neukum
2008-03-25 14:33 ` Alan Stern
2008-03-25 14:33 ` [linux-pm] " Alan Stern
2008-03-25 14:33 ` Alan Stern
2008-03-25 19:48 ` Oliver Neukum
2008-03-25 19:48 ` [linux-pm] " Oliver Neukum
2008-03-25 19:48 ` Oliver Neukum
2008-03-25 20:41 ` Rafael J. Wysocki
2008-03-25 20:41 ` Rafael J. Wysocki
2008-03-25 20:49 ` Oliver Neukum
2008-03-25 20:49 ` Oliver Neukum
2008-03-25 20:56 ` Rafael J. Wysocki
2008-03-25 20:56 ` Rafael J. Wysocki
2008-03-26 14:10 ` Alan Stern
2008-03-26 14:10 ` [linux-pm] " Alan Stern
2008-03-26 14:10 ` Alan Stern
2008-03-26 14:24 ` Oliver Neukum
2008-03-26 14:24 ` Oliver Neukum
2008-03-26 14:40 ` Alan Stern
2008-03-26 14:40 ` [linux-pm] " Alan Stern
2008-03-26 14:40 ` Alan Stern
2008-03-26 15:42 ` Oliver Neukum
2008-03-26 15:42 ` Oliver Neukum
2008-03-26 16:36 ` Alan Stern
2008-03-26 16:36 ` [linux-pm] " Alan Stern
2008-03-26 16:36 ` Alan Stern
2008-03-26 20:46 ` Rafael J. Wysocki
2008-03-27 2:48 ` Alan Stern
2008-03-27 2:48 ` Alan Stern
2008-03-27 2:48 ` Alan Stern
2008-03-26 20:46 ` Rafael J. Wysocki
2008-03-26 15:42 ` Oliver Neukum
2008-03-26 14:24 ` Oliver Neukum
2008-03-25 20:56 ` Rafael J. Wysocki
2008-03-25 20:49 ` Oliver Neukum
2008-03-25 20:41 ` Rafael J. Wysocki
2008-03-25 14:24 ` Oliver Neukum
2008-03-25 13:15 ` Oliver Neukum
2008-03-25 9:49 ` Oliver Neukum
2008-03-21 0:21 ` Johannes Berg
2008-03-21 1:21 ` Alan Stern
2008-03-21 1:21 ` Alan Stern
2008-03-21 2:14 ` Rafael J. Wysocki
2008-03-21 2:53 ` Alan Stern
2008-03-21 2:53 ` Alan Stern
2008-03-22 22:17 ` Rafael J. Wysocki
2008-03-22 22:17 ` Rafael J. Wysocki
2008-03-22 23:28 ` Alan Stern
2008-03-22 23:44 ` Rafael J. Wysocki
2008-03-22 23:44 ` Rafael J. Wysocki
2008-03-23 2:07 ` Alan Stern
2008-03-23 18:41 ` Rafael J. Wysocki
2008-03-23 18:41 ` Rafael J. Wysocki
2008-03-23 2:07 ` Alan Stern
2008-03-22 23:28 ` Alan Stern
2008-03-21 2:14 ` Rafael J. Wysocki
2008-03-21 8:15 ` Sam Ravnborg
2008-03-23 21:16 ` Rafael J. Wysocki
2008-03-23 21:16 ` Rafael J. Wysocki
2008-03-21 8:15 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803251049.27696.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=astarikovskiy@suse.de \
--cc=johannes@sipsolutions.net \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.