From: Len Brown <lenb@kernel.org>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-acpi@vger.kernel.org,
Johann-Nikolaus Andreae <johann-nikolaus.andreae@nacs.de>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [patch] ACPI: fix Medion _PRT quirk (use "ISA_", not "ISA")
Date: Tue, 25 Mar 2008 20:30:06 -0400 [thread overview]
Message-ID: <200803252030.07141.lenb@kernel.org> (raw)
In-Reply-To: <200803251121.13050.bjorn.helgaas@hp.com>
applied.
thanks,
-Len
On Tuesday 25 March 2008, Bjorn Helgaas wrote:
> [It would be nice to have this in 2.6.25. It only affects the
> builtin NIC on the Medion MD9580-F laptop, which is currently
> broken due to an IRQ routing problem, and Johann-Nikolaus has
> verified that this fixes the problem.]
>
> This fixes the builtin RTL8139 NIC on the Medion MD9580-F laptop.
> The BIOS reports the interrupt routing incorrectly. I recently
> added a quirk to work around this, and this patch fixes a typo
> in the quirk.
>
> We pad every ACPI pathname component to four characters, so ".ISA."
> will never match anything. We need ".ISA_." instead.
>
> Thank you Johann-Nikolaus Andreae <johann-nikolaus.andreae@nacs.de>
> for patiently testing this patch.
>
> See http://bugzilla.kernel.org/show_bug.cgi?id=4773
>
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
>
> Index: work7/drivers/acpi/pci_irq.c
> ===================================================================
> --- work7.orig/drivers/acpi/pci_irq.c 2008-03-25 08:51:42.000000000 -0600
> +++ work7/drivers/acpi/pci_irq.c 2008-03-25 08:52:03.000000000 -0600
> @@ -131,8 +131,8 @@
> */
> static struct prt_quirk prt_quirks[] = {
> { medion_md9580, 0, 0, 9, 'A',
> - "\\_SB_.PCI0.ISA.LNKA",
> - "\\_SB_.PCI0.ISA.LNKB"},
> + "\\_SB_.PCI0.ISA_.LNKA",
> + "\\_SB_.PCI0.ISA_.LNKB"},
> { dell_optiplex, 0, 0, 0xd, 'A',
> "\\_SB_.LNKB",
> "\\_SB_.LNKA"},
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2008-03-26 0:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-25 17:21 [patch] ACPI: fix Medion _PRT quirk (use "ISA_", not "ISA") Bjorn Helgaas
2008-03-26 0:30 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803252030.07141.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bjorn.helgaas@hp.com \
--cc=johann-nikolaus.andreae@nacs.de \
--cc=linux-acpi@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.