* [patch] ACPI: fix Medion _PRT quirk (use "ISA_", not "ISA")
@ 2008-03-25 17:21 Bjorn Helgaas
2008-03-26 0:30 ` Len Brown
0 siblings, 1 reply; 2+ messages in thread
From: Bjorn Helgaas @ 2008-03-25 17:21 UTC (permalink / raw)
To: Andrew Morton
Cc: Len Brown, linux-acpi, Johann-Nikolaus Andreae, Linus Torvalds
[It would be nice to have this in 2.6.25. It only affects the
builtin NIC on the Medion MD9580-F laptop, which is currently
broken due to an IRQ routing problem, and Johann-Nikolaus has
verified that this fixes the problem.]
This fixes the builtin RTL8139 NIC on the Medion MD9580-F laptop.
The BIOS reports the interrupt routing incorrectly. I recently
added a quirk to work around this, and this patch fixes a typo
in the quirk.
We pad every ACPI pathname component to four characters, so ".ISA."
will never match anything. We need ".ISA_." instead.
Thank you Johann-Nikolaus Andreae <johann-nikolaus.andreae@nacs.de>
for patiently testing this patch.
See http://bugzilla.kernel.org/show_bug.cgi?id=4773
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Index: work7/drivers/acpi/pci_irq.c
===================================================================
--- work7.orig/drivers/acpi/pci_irq.c 2008-03-25 08:51:42.000000000 -0600
+++ work7/drivers/acpi/pci_irq.c 2008-03-25 08:52:03.000000000 -0600
@@ -131,8 +131,8 @@
*/
static struct prt_quirk prt_quirks[] = {
{ medion_md9580, 0, 0, 9, 'A',
- "\\_SB_.PCI0.ISA.LNKA",
- "\\_SB_.PCI0.ISA.LNKB"},
+ "\\_SB_.PCI0.ISA_.LNKA",
+ "\\_SB_.PCI0.ISA_.LNKB"},
{ dell_optiplex, 0, 0, 0xd, 'A',
"\\_SB_.LNKB",
"\\_SB_.LNKA"},
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [patch] ACPI: fix Medion _PRT quirk (use "ISA_", not "ISA")
2008-03-25 17:21 [patch] ACPI: fix Medion _PRT quirk (use "ISA_", not "ISA") Bjorn Helgaas
@ 2008-03-26 0:30 ` Len Brown
0 siblings, 0 replies; 2+ messages in thread
From: Len Brown @ 2008-03-26 0:30 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Andrew Morton, linux-acpi, Johann-Nikolaus Andreae,
Linus Torvalds
applied.
thanks,
-Len
On Tuesday 25 March 2008, Bjorn Helgaas wrote:
> [It would be nice to have this in 2.6.25. It only affects the
> builtin NIC on the Medion MD9580-F laptop, which is currently
> broken due to an IRQ routing problem, and Johann-Nikolaus has
> verified that this fixes the problem.]
>
> This fixes the builtin RTL8139 NIC on the Medion MD9580-F laptop.
> The BIOS reports the interrupt routing incorrectly. I recently
> added a quirk to work around this, and this patch fixes a typo
> in the quirk.
>
> We pad every ACPI pathname component to four characters, so ".ISA."
> will never match anything. We need ".ISA_." instead.
>
> Thank you Johann-Nikolaus Andreae <johann-nikolaus.andreae@nacs.de>
> for patiently testing this patch.
>
> See http://bugzilla.kernel.org/show_bug.cgi?id=4773
>
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
>
> Index: work7/drivers/acpi/pci_irq.c
> ===================================================================
> --- work7.orig/drivers/acpi/pci_irq.c 2008-03-25 08:51:42.000000000 -0600
> +++ work7/drivers/acpi/pci_irq.c 2008-03-25 08:52:03.000000000 -0600
> @@ -131,8 +131,8 @@
> */
> static struct prt_quirk prt_quirks[] = {
> { medion_md9580, 0, 0, 9, 'A',
> - "\\_SB_.PCI0.ISA.LNKA",
> - "\\_SB_.PCI0.ISA.LNKB"},
> + "\\_SB_.PCI0.ISA_.LNKA",
> + "\\_SB_.PCI0.ISA_.LNKB"},
> { dell_optiplex, 0, 0, 0xd, 'A',
> "\\_SB_.LNKB",
> "\\_SB_.LNKA"},
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-26 0:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-25 17:21 [patch] ACPI: fix Medion _PRT quirk (use "ISA_", not "ISA") Bjorn Helgaas
2008-03-26 0:30 ` Len Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.