* Re: [PATCH] pata_sil680: Only enable MMIO on Cell blades
2008-03-25 23:50 ` Benjamin Herrenschmidt
@ 2008-03-25 23:49 ` Alan Cox
-1 siblings, 0 replies; 4+ messages in thread
From: Alan Cox @ 2008-03-25 23:49 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: jgarzik, Linux IDE, linux-kernel
On Wed, 26 Mar 2008 10:50:41 +1100
Benjamin Herrenschmidt <benh@ozlabs.org> wrote:
> There have been reported regressions of the SIL 680 driver when
> using MMIO, so this makes it only try MMIO on Cell blades where
> it's known to be necessary (the host bridge doesn't do PIO on these).
>
> We'll try to find the root problem with MMIO separately.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Alan Cox <alan@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pata_sil680: Only enable MMIO on Cell blades
@ 2008-03-25 23:49 ` Alan Cox
0 siblings, 0 replies; 4+ messages in thread
From: Alan Cox @ 2008-03-25 23:49 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: jgarzik, Linux IDE, linux-kernel
On Wed, 26 Mar 2008 10:50:41 +1100
Benjamin Herrenschmidt <benh@ozlabs.org> wrote:
> There have been reported regressions of the SIL 680 driver when
> using MMIO, so this makes it only try MMIO on Cell blades where
> it's known to be necessary (the host bridge doesn't do PIO on these).
>
> We'll try to find the root problem with MMIO separately.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Alan Cox <alan@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] pata_sil680: Only enable MMIO on Cell blades
@ 2008-03-25 23:50 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2008-03-25 23:50 UTC (permalink / raw)
To: jgarzik; +Cc: Linux IDE, linux-kernel
There have been reported regressions of the SIL 680 driver when
using MMIO, so this makes it only try MMIO on Cell blades where
it's known to be necessary (the host bridge doesn't do PIO on these).
We'll try to find the root problem with MMIO separately.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
drivers/ata/pata_sil680.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
--- linux-work.orig/drivers/ata/pata_sil680.c 2008-03-26 10:43:20.000000000 +1100
+++ linux-work/drivers/ata/pata_sil680.c 2008-03-26 10:43:34.000000000 +1100
@@ -269,7 +269,11 @@ static u8 sil680_init_chip(struct pci_de
dev_dbg(&pdev->dev, "sil680: BA5_EN = %d clock = %02X\n",
tmpbyte & 1, tmpbyte & 0x30);
- *try_mmio = (tmpbyte & 1) || pci_resource_start(pdev, 5);
+ *try_mmio = 0;
+#ifdef CONFIG_PPC
+ if (machine_is(cell))
+ *try_mmio = (tmpbyte & 1) || pci_resource_start(pdev, 5);
+#endif
switch(tmpbyte & 0x30) {
case 0x00:
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] pata_sil680: Only enable MMIO on Cell blades
@ 2008-03-25 23:50 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2008-03-25 23:50 UTC (permalink / raw)
To: jgarzik; +Cc: Linux IDE, linux-kernel
There have been reported regressions of the SIL 680 driver when
using MMIO, so this makes it only try MMIO on Cell blades where
it's known to be necessary (the host bridge doesn't do PIO on these).
We'll try to find the root problem with MMIO separately.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
drivers/ata/pata_sil680.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
--- linux-work.orig/drivers/ata/pata_sil680.c 2008-03-26 10:43:20.000000000 +1100
+++ linux-work/drivers/ata/pata_sil680.c 2008-03-26 10:43:34.000000000 +1100
@@ -269,7 +269,11 @@ static u8 sil680_init_chip(struct pci_de
dev_dbg(&pdev->dev, "sil680: BA5_EN = %d clock = %02X\n",
tmpbyte & 1, tmpbyte & 0x30);
- *try_mmio = (tmpbyte & 1) || pci_resource_start(pdev, 5);
+ *try_mmio = 0;
+#ifdef CONFIG_PPC
+ if (machine_is(cell))
+ *try_mmio = (tmpbyte & 1) || pci_resource_start(pdev, 5);
+#endif
switch(tmpbyte & 0x30) {
case 0x00:
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-03-26 0:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-25 23:50 [PATCH] pata_sil680: Only enable MMIO on Cell blades Benjamin Herrenschmidt
2008-03-25 23:50 ` Benjamin Herrenschmidt
2008-03-25 23:49 ` Alan Cox
2008-03-25 23:49 ` Alan Cox
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.