From: David Miller <davem@davemloft.net>
To: xemul@openvz.org
Cc: herbert@gondor.apana.org.au, den@openvz.org,
netdev@vger.kernel.org, devel@openvz.org
Subject: Re: [PATCH][ICMP]: Dst entry leak in icmp_send host re-lookup code (v2).
Date: Wed, 26 Mar 2008 02:27:33 -0700 (PDT) [thread overview]
Message-ID: <20080326.022733.159053599.davem@davemloft.net> (raw)
In-Reply-To: <47EA1694.1080208@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Wed, 26 Mar 2008 12:25:40 +0300
> Commit 8b7817f3a959ed99d7443afc12f78a7e1fcc2063 ([IPSEC]: Add ICMP host
> relookup support) introduced some dst leaks on error paths: the rt
> pointer can be forgotten to be put. Fix it bu going to a proper label.
>
> Found after net namespace's lo refused to unregister :) Many thanks to
> Den for valuable help during debugging.
>
> Herbert pointed out, that xfrm_lookup() will put the rtable in case
> of error itself, so the first goto fix is redundant.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
Looks good, applied, thanks!
next prev parent reply other threads:[~2008-03-26 9:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 9:25 [PATCH][ICMP]: Dst entry leak in icmp_send host re-lookup code (v2) Pavel Emelyanov
2008-03-26 9:27 ` David Miller [this message]
2008-04-01 12:15 ` Herbert Xu
2008-04-02 7:06 ` David Miller
2008-04-02 9:19 ` Julian Anastasov
2008-04-02 12:40 ` Herbert Xu
2008-04-02 23:29 ` Julian Anastasov
2008-04-03 20:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080326.022733.159053599.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=den@openvz.org \
--cc=devel@openvz.org \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.