All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: xemul@openvz.org, den@openvz.org, netdev@vger.kernel.org,
	devel@openvz.org
Subject: Re: [PATCH][ICMP]: Dst entry leak in icmp_send host re-lookup code (v2).
Date: Wed, 02 Apr 2008 00:06:29 -0700 (PDT)	[thread overview]
Message-ID: <20080402.000629.39145635.davem@davemloft.net> (raw)
In-Reply-To: <20080401121532.GA24470@gondor.apana.org.au>

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Tue, 1 Apr 2008 20:15:32 +0800

> On Wed, Mar 26, 2008 at 12:25:40PM +0300, Pavel Emelyanov wrote:
> > Commit 8b7817f3a959ed99d7443afc12f78a7e1fcc2063 ([IPSEC]: Add ICMP host
> > relookup support) introduced some dst leaks on error paths: the rt
> > pointer can be forgotten to be put. Fix it bu going to a proper label.
> 
> I just remembered that we have exactly the same code path in IPv6
> and sure enough it also has the same bug.
> 
> [IPV6]: Fix ICMP relookup error path dst leak
> 
> When we encounter an error while looking up the dst the second
> time we need to drop the first dst.  This patch is pretty much
> the same as the one for IPv4.
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Applied, thanks for catching this.

  reply	other threads:[~2008-04-02  7:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-26  9:25 [PATCH][ICMP]: Dst entry leak in icmp_send host re-lookup code (v2) Pavel Emelyanov
2008-03-26  9:27 ` David Miller
2008-04-01 12:15 ` Herbert Xu
2008-04-02  7:06   ` David Miller [this message]
2008-04-02  9:19   ` Julian Anastasov
2008-04-02 12:40     ` Herbert Xu
2008-04-02 23:29       ` Julian Anastasov
2008-04-03 20:00       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080402.000629.39145635.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=den@openvz.org \
    --cc=devel@openvz.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.