[PATCH] don't export ext3_fs.h and jbd.h

[PATCH] don't export ext3_fs.h and jbd.h

[Christoph Hellwig]

either of the headers actually compiles when included from userpsace
nor should it be made available as userspace tools should be using
the libraries or at least headers from e2fsprogs.


Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: linux-2.6/include/linux/Kbuild
===================================================================
--- linux-2.6.orig/include/linux/Kbuild	2008-03-24 13:04:08.000000000 +0100
+++ linux-2.6/include/linux/Kbuild	2008-03-24 13:04:17.000000000 +0100
@@ -195,7 +195,6 @@ unifdef-y += ethtool.h
 unifdef-y += eventpoll.h
 unifdef-y += signalfd.h
 unifdef-y += ext2_fs.h
-unifdef-y += ext3_fs.h
 unifdef-y += fb.h
 unifdef-y += fcntl.h
 unifdef-y += filter.h
@@ -248,7 +247,6 @@ unifdef-y += isdn.h
 unifdef-y += isdnif.h
 unifdef-y += isdn_divertif.h
 unifdef-y += isdn_ppp.h
-unifdef-y += jbd.h
 unifdef-y += joystick.h
 unifdef-y += kdev_t.h
 unifdef-y += kd.h

Re: [PATCH] don't export ext3_fs.h and jbd.h

[Theodore Tso]

On Wed, Mar 26, 2008 at 11:46:22PM +0100, Christoph Hellwig wrote:
> either of the headers actually compiles when included from userpsace
> nor should it be made available as userspace tools should be using
> the libraries or at least headers from e2fsprogs.

I was planning on simply moving ext3_fs.h to fs/ext3, per your
previously submitted patches.

I agree that removing jbd.h from the exported list makes sense.

Acked-by: "Theodore Ts'o" <tytso@mit.edu>

							- Ted

Re: [PATCH] don't export ext3_fs.h and jbd.h

[Christoph Hellwig]

On Wed, Mar 26, 2008 at 07:30:38PM -0400, Theodore Tso wrote:
> On Wed, Mar 26, 2008 at 11:46:22PM +0100, Christoph Hellwig wrote:
> > either of the headers actually compiles when included from userpsace
> > nor should it be made available as userspace tools should be using
> > the libraries or at least headers from e2fsprogs.
> 
> I was planning on simply moving ext3_fs.h to fs/ext3, per your
> previously submitted patches.
> 
> I agree that removing jbd.h from the exported list makes sense.

Let's get it out of the exported headers list for .25 so people can't
accidentally include it anymore and do the big reshuffle for .26, ok?

Re: [PATCH] don't export ext3_fs.h and jbd.h

[Theodore Tso]

On Thu, Mar 27, 2008 at 12:37:13AM +0100, Christoph Hellwig wrote:
> 
> Let's get it out of the exported headers list for .25 so people can't
> accidentally include it anymore and do the big reshuffle for .26, ok?

It's OK with me; I'm not sure the Great Penguin would consider it to
be a bug fix, though.  We can always ask...

							- Ted

Re: [PATCH] don't export ext3_fs.h and jbd.h

[Andrew Morton]

On Thu, 27 Mar 2008 06:01:04 -0400 Theodore Tso <tytso@MIT.EDU> wrote:

> On Thu, Mar 27, 2008 at 12:37:13AM +0100, Christoph Hellwig wrote:
> > 
> > Let's get it out of the exported headers list for .25 so people can't
> > accidentally include it anymore and do the big reshuffle for .26, ok?
> 
> It's OK with me; I'm not sure the Great Penguin would consider it to
> be a bug fix, though.  We can always ask...
> 

I queued it for 2.6.25.