Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend and hibernation callbacks (rev. 4)

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Thursday, 27 of March 2008, Alan Stern wrote:
> On Thu, 27 Mar 2008, Rafael J. Wysocki wrote:
> 
> > @@ -68,22 +75,32 @@ int device_pm_add(struct device *dev)
> >  		 dev->bus ? dev->bus->name : "No Bus",
> >  		 kobject_name(&dev->kobj));
> >  	mutex_lock(&dpm_list_mtx);
> > -	if ((dev->parent && dev->parent->power.sleeping) || all_sleeping) {
> > -		if (dev->parent->power.sleeping)
> > -			dev_warn(dev,
> > -				"parent %s is sleeping, will not add\n",
> > +	if (dev->parent) {
> > +		if (dev->parent->power.status >= DPM_SUSPENDING) {
> > +			dev_warn(dev, "parent %s is sleeping, will not add\n",
> >  				dev->parent->bus_id);
> 
> You forgot to check for dev->parent->power.status == DPM_INVALID.

Right, will fix.

Thanks,
Rafael