From: Alexey Starikovskiy <astarikovskiy@suse.de>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: pm list <linux-pm@lists.linux-foundation.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Alan Stern <stern@rowland.harvard.edu>, Greg KH <greg@kroah.com>,
Len Brown <lenb@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
David Brownell <david-b@pacbell.net>, Pavel Machek <pavel@ucw.cz>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Oliver Neukum <oliver@neukum.org>
Subject: Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend and hibernation callbacks (rev. 4)
Date: Thu, 27 Mar 2008 02:27:12 +0300 [thread overview]
Message-ID: <47EADBD0.6040400@suse.de> (raw)
In-Reply-To: <200803270003.51570.rjw@sisk.pl>
Rafael J. Wysocki wrote:
> This is the 4th revision of the patch.
> + * struct pm_noirq_ops - device PM callbacks executed with interrupts disabled
> + *
> + * The following callbacks included in 'struct pm_noirq_ops' are executed with
> + * the nonboot CPUs switched off and with interrupts disabled on the only
> + * functional CPU. They also are executed with the PM core list of devices
> + * locked, so they must NOT unregister any devices.
> + *
> + * @suspend_noirq: Complete the operations of ->suspend() by carrying out any
> + * actions required for suspending the device that need interrupts to be
> + * disabled
IMHO, no need to add _noirq in both struct and struct members.
pm_noirq->suspend_noirq does not look good...
next prev parent reply other threads:[~2008-03-26 23:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 22:53 [RFC][PATCH 0/3] PM: Rework suspend and hibernation code for devices (rev. 2) Rafael J. Wysocki
2008-03-26 23:03 ` [RFC][PATCH 1/3] PM: Introduce new top level suspend and hibernation callbacks (rev. 4) Rafael J. Wysocki
2008-03-26 23:03 ` Rafael J. Wysocki
2008-03-26 23:03 ` Rafael J. Wysocki
2008-03-26 23:27 ` Alexey Starikovskiy
2008-03-26 23:27 ` Alexey Starikovskiy [this message]
2008-03-26 23:43 ` Benjamin Herrenschmidt
2008-03-26 23:43 ` Benjamin Herrenschmidt
2008-03-26 23:54 ` Rafael J. Wysocki
2008-03-27 0:06 ` Benjamin Herrenschmidt
2008-03-27 0:06 ` Benjamin Herrenschmidt
2008-03-27 1:23 ` Rafael J. Wysocki
2008-03-27 2:52 ` Benjamin Herrenschmidt
2008-03-27 2:52 ` Benjamin Herrenschmidt
2008-03-27 16:33 ` Rafael J. Wysocki
2008-03-27 16:33 ` Rafael J. Wysocki
2008-03-27 1:23 ` Rafael J. Wysocki
2008-03-26 23:54 ` Rafael J. Wysocki
2008-03-26 23:59 ` Rafael J. Wysocki
2008-03-26 23:59 ` Rafael J. Wysocki
2008-03-27 1:12 ` Rafael J. Wysocki
2008-03-27 1:12 ` Rafael J. Wysocki
2008-03-27 3:09 ` Alan Stern
2008-03-27 16:24 ` Rafael J. Wysocki
2008-03-27 16:24 ` Rafael J. Wysocki
2008-03-27 3:09 ` Alan Stern
2008-03-27 1:12 ` Rafael J. Wysocki
2008-03-26 23:05 ` [RFC][PATCH 2/3] PM: New suspend and hibernation callbacks for platform bus type (rev. 2) Rafael J. Wysocki
2008-03-26 23:05 ` Rafael J. Wysocki
2008-03-26 23:06 ` [RFC][PATCH 3/3] PM: New suspend and hibernation callbacks for PCI " Rafael J. Wysocki
2008-03-26 23:06 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47EADBD0.6040400@suse.de \
--to=astarikovskiy@suse.de \
--cc=benh@kernel.crashing.org \
--cc=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=oliver@neukum.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.