From: Olof Johansson <olof@lixom.net>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org, Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH] Make pasemi_mac.c depend on PPC_PASEMI to prevent link errors
Date: Thu, 27 Mar 2008 20:54:14 -0500 [thread overview]
Message-ID: <20080328015414.GA23856@lixom.net> (raw)
In-Reply-To: <c9b4b088d00e37e33907b15ac59450c04ef36112.1206666963.git.michael@ellerman.id.au>
On Fri, Mar 28, 2008 at 12:17:33PM +1100, Michael Ellerman wrote:
> drivers/net/pasemi_mac.c is enabled by CONFIG_PASEMI_MAC, which depends on
> PPC64 && PCI. However pasemi_mac.c uses several routines that are only
> built when PPC_PASEMI is selected. This can lead to an unbuildable config:
>
> ERROR: ".pasemi_dma_start_chan" [drivers/net/pasemi_mac.ko] undefined!
>
> So make CONFIG_PASEMI_MAC depend on PPC_PASEMI instead of PPC64.
>
Ah, good catch. It was OK until I introduced dma_lib under
platforms/pasemi.
> Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Acked-by: Olof Johansson <olof@lixom.net>
-Olof
next prev parent reply other threads:[~2008-03-28 1:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 1:17 [PATCH] Make pasemi_mac.c depend on PPC_PASEMI to prevent link errors Michael Ellerman
2008-03-28 1:54 ` Olof Johansson [this message]
2008-03-29 1:53 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080328015414.GA23856@lixom.net \
--to=olof@lixom.net \
--cc=jeff@garzik.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.