From: Jeff Garzik <jeff@garzik.org>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: Olof Johannsson <olof@lixom.net>, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Make pasemi_mac.c depend on PPC_PASEMI to prevent link errors
Date: Fri, 28 Mar 2008 21:53:57 -0400 [thread overview]
Message-ID: <47EDA135.9040003@garzik.org> (raw)
In-Reply-To: <c9b4b088d00e37e33907b15ac59450c04ef36112.1206666963.git.michael@ellerman.id.au>
Michael Ellerman wrote:
> drivers/net/pasemi_mac.c is enabled by CONFIG_PASEMI_MAC, which depends on
> PPC64 && PCI. However pasemi_mac.c uses several routines that are only
> built when PPC_PASEMI is selected. This can lead to an unbuildable config:
>
> ERROR: ".pasemi_dma_start_chan" [drivers/net/pasemi_mac.ko] undefined!
>
> So make CONFIG_PASEMI_MAC depend on PPC_PASEMI instead of PPC64.
>
> Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
> ---
> drivers/net/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>
>
> Jeff, pending Olof's ack, this would be nice for 25, but is obviously
> not super important.
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index fe7b5ec..3a0b20a 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2635,7 +2635,7 @@ config NIU
>
> config PASEMI_MAC
> tristate "PA Semi 1/10Gbit MAC"
> - depends on PPC64 && PCI
> + depends on PPC_PASEMI && PCI
> select PHYLIB
applied
prev parent reply other threads:[~2008-03-29 1:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 1:17 [PATCH] Make pasemi_mac.c depend on PPC_PASEMI to prevent link errors Michael Ellerman
2008-03-28 1:54 ` Olof Johansson
2008-03-29 1:53 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47EDA135.9040003@garzik.org \
--to=jeff@garzik.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.